Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add TORCH backend for RandHistogramShift #4567

Merged
merged 4 commits into from
Jun 23, 2022

Conversation

dyollb
Copy link
Contributor

@dyollb dyollb commented Jun 23, 2022

Signed-off-by: Bryn Lloyd [email protected]

Fixes #4565

Description

Currently the only transform in our augmentation pipeline that doesn't have a TORCH backend is the RandHistogramShiftd.
I have not profiled the speedup and GPU memory for the augmentation transforms, but I guess if we could do most of it on the GPU it should improve performance.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@dyollb dyollb force-pushed the 4565-randhistogramshift-torch-backend branch from d325849 to e480ada Compare June 23, 2022 12:03
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, I'll merge this if all tests are ok

@wyli
Copy link
Contributor

wyli commented Jun 23, 2022

/build

@wyli wyli merged commit ca165d8 into Project-MONAI:dev Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TORCH backend for RandHistogramShift transform
2 participants