Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenSlide support for new WSIReader #4155

Merged
merged 8 commits into from
Apr 22, 2022
Merged

Conversation

drbeh
Copy link
Member

@drbeh drbeh commented Apr 20, 2022

Fixes #4154

Description

This PR implement OpenSlideWSIReader, which read patches from whole slide images using openslide library in the back.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@drbeh drbeh requested a review from Nic-Ma April 20, 2022 20:12
Signed-off-by: Behrooz <[email protected]>
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for some minor comments inline.

Thanks.

monai/data/wsi_reader.py Outdated Show resolved Hide resolved
monai/data/wsi_reader.py Outdated Show resolved Hide resolved
monai/data/wsi_reader.py Show resolved Hide resolved
monai/data/wsi_reader.py Outdated Show resolved Hide resolved
monai/data/wsi_reader.py Outdated Show resolved Hide resolved
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
@drbeh drbeh self-assigned this Apr 21, 2022
@drbeh drbeh linked an issue Apr 21, 2022 that may be closed by this pull request
Signed-off-by: Behrooz <[email protected]>
@drbeh drbeh enabled auto-merge (squash) April 21, 2022 21:54
@drbeh
Copy link
Member Author

drbeh commented Apr 22, 2022

@Nic-Ma can you /build here? Thanks

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Apr 22, 2022

/build

3 similar comments
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Apr 22, 2022

/build

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Apr 22, 2022

/build

@pxLi
Copy link
Contributor

pxLi commented Apr 22, 2022

/build

@drbeh drbeh merged commit ed70e11 into Project-MONAI:dev Apr 22, 2022
@drbeh drbeh deleted the openslide-new branch April 25, 2022 14:58
Can-Zhao pushed a commit to Can-Zhao/MONAI that referenced this pull request May 10, 2022
* Implement WSIReader with OpenSlide backend .

Signed-off-by: Behrooz <[email protected]>

* Add unittest for openslide

Signed-off-by: Behrooz <[email protected]>

* Add docs

Signed-off-by: Behrooz <[email protected]>

* formatting

Signed-off-by: Behrooz <[email protected]>

* Update imports and few fixes

Signed-off-by: Behrooz <[email protected]>

* Fix x,y in docstrings

Signed-off-by: Behrooz <[email protected]>

* Address comments

Signed-off-by: Behrooz <[email protected]>

* Remove x and y

Signed-off-by: Behrooz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docstrings in wsi_reader.py are not consistent Add OpenSlide support for new WSIReader
3 participants