Skip to content

3482 - update bundle doc #3982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Mar 30, 2022
Merged

3482 - update bundle doc #3982

merged 21 commits into from
Mar 30, 2022

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Mar 22, 2022 •
edited
Loading

Signed-off-by: Wenqi Li [email protected]

part of #3482

Description

preview here https://github.com/wyli/MONAI/blob/3482-bundle-doc/docs/source/config_syntax.md

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli mentioned this pull request Mar 22, 2022
Closed
17 tasks
@wyli
Copy link
Contributor Author

wyli commented Mar 23, 2022

/integration-test

@wyli wyli force-pushed the 3482-bundle-doc branch from 2d0ec56 to 3aed2cd Compare March 24, 2022 16:20
wyli added 2 commits March 24, 2022 16:28
@wyli
update meta
552164c 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
update intro
0461f16 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 3482-bundle-doc branch 3 times, most recently from 6584161 to 84cd0f1 Compare March 24, 2022 23:38
@wyli
update examples
20d35c6 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 3482-bundle-doc branch from 84cd0f1 to 20d35c6 Compare March 24, 2022 23:46
Nic-Ma
Nic-Ma reviewed Mar 28, 2022
View reviewed changes
Nic-Ma
Nic-Ma reviewed Mar 28, 2022
View reviewed changes
@Nic-Ma Nic-Ma mentioned this pull request Mar 29, 2022
Merged
1 task
wyli added 2 commits March 29, 2022 17:00
@wyli
adds yaml demo
43ded13 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
update schema
99f83ad 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 3482-bundle-doc branch from 3370e1c to b4ca806 Compare March 29, 2022 16:55
@wyli
update toc
e0ea592 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 3482-bundle-doc branch from b4ca806 to e0ea592 Compare March 29, 2022 16:58
@wyli
update doc page
2914787 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 3482-bundle-doc branch from 0f0ae09 to 2914787 Compare March 29, 2022 18:59
@wyli wyli force-pushed the 3482-bundle-doc branch 2 times, most recently from 999d044 to 90272ee Compare March 30, 2022 09:39
@wyli
$import
41e01ed 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 3482-bundle-doc branch from 90272ee to 41e01ed Compare March 30, 2022 09:40
@wyli wyli requested a review from Nic-Ma March 30, 2022 09:59
@wyli
adds recommendations
d927a28 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 3482-bundle-doc branch from ef32c85 to d927a28 Compare March 30, 2022 10:01
@wyli wyli marked this pull request as ready for review March 30, 2022 10:27
@wyli
update config
69a89b3 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 3482-bundle-doc branch from 0a1106e to 69a89b3 Compare March 30, 2022 11:06
Nic-Ma
Nic-Ma reviewed Mar 30, 2022
View reviewed changes
@wyli wyli force-pushed the 3482-bundle-doc branch from 9f61353 to 5083874 Compare March 30, 2022 12:00
Nic-Ma
Nic-Ma approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update.
Looks good to me.

Thanks.

@wyli wyli force-pushed the 3482-bundle-doc branch from 0082245 to 76b1a8d Compare March 30, 2022 12:20
@wyli
Copy link
Contributor Author

wyli commented Mar 30, 2022

/build

@wyli wyli enabled auto-merge (squash) March 30, 2022 13:11
@wyli wyli merged commit 3947d4e into Project-MONAI:dev Mar 30, 2022
@wyli wyli deleted the 3482-bundle-doc branch April 27, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wyli @Nic-Ma