Skip to content

3482 3829 Add ConfigParser to recursively parse config content #3822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Mar 1, 2022
Merged

3482 3829 Add ConfigParser to recursively parse config content #3822

merged 32 commits into from
Mar 1, 2022

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Feb 19, 2022 •
edited
Loading

Task step 3-2 of #3482 .
Fixes #3829

Description

This PR added the ConfigParser to recursively parse config content.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 19, 2022

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 19, 2022

/build

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli February 19, 2022 04:32
@Nic-Ma Nic-Ma mentioned this pull request Feb 19, 2022
Closed
17 tasks
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 19, 2022

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 20, 2022

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 20, 2022

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 20, 2022 •
edited
Loading

Hi @wyli @ericspod ,

I have simplified the parse logic and removed self.parsed status flag.
And added 3 levels operations for the lazy config in the doc-string of ConfigParser:
get_config, get_config_item(resolve=True/False), get_resolved_content

Could you please help review it again?

Thanks in advance.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 21, 2022

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 21, 2022

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 21, 2022

/build

@wyli wyli mentioned this pull request Feb 21, 2022
Closed
@Nic-Ma Nic-Ma changed the title 3482 Add ConfigParser to recursively parse config content 3482 3829 Add ConfigParser to recursively parse config content Feb 21, 2022
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 21, 2022

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 21, 2022

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 21, 2022

/black

@Nic-Ma Nic-Ma enabled auto-merge (squash) February 24, 2022 03:45
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 24, 2022

/build

2 similar comments
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 24, 2022

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 24, 2022

/build

@Nic-Ma Nic-Ma force-pushed the 3482-add-config-parser branch from e70d663 to 4492a91 Compare February 24, 2022 10:06
@wyli wyli force-pushed the 3482-add-config-parser branch from ab21c3f to 43ce0e5 Compare February 24, 2022 10:22
@Nic-Ma
[DLMED] update code
b86f897 
Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma
[DLMED] update doc
28c5c07 
Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 24, 2022

/build

@wyli wyli force-pushed the 3482-add-config-parser branch from a9c984c to 33b0239 Compare February 24, 2022 11:04
@Nic-Ma Nic-Ma mentioned this pull request Feb 24, 2022
Merged
7 tasks
@wyli
update usage
7d2903f 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 3482-add-config-parser branch from 7583a4e to f5db958 Compare February 24, 2022 23:36
wyli added 2 commits February 24, 2022 23:44
@wyli
update regex for <args>
337c51d 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
revise docstring
5b693bb 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 3482-add-config-parser branch from f5db958 to 5b693bb Compare February 24, 2022 23:44
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 25, 2022

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 25, 2022

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 25, 2022

/build

2 similar comments
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 27, 2022

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 28, 2022

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 1, 2022

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 1, 2022

Hi @wyli @ericspod ,

I have updated the module name from monai.apps.manifest to monai.bundle, could you please help double confirm it again?

Thanks in advance.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 1, 2022

/black

Nic-Ma
Nic-Ma commented Mar 1, 2022
View reviewed changes
@Nic-Ma Nic-Ma merged commit dbd3da3 into Project-MONAI:dev Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@rijobro rijobro Awaiting requested review from rijobro

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tests.test_config_item

2 participants

@Nic-Ma @wyli