Skip to content

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Sep 22, 2021

  • update to use cucim>=21.8.2
  • skip cucim related tests if not hasattr(cucim, "CuImage")
  • use tifffile to create test cases instead of PIL

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli marked this pull request as ready for review September 22, 2021 16:52
@wyli wyli requested a review from Nic-Ma September 22, 2021 16:52
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli enabled auto-merge (squash) September 22, 2021 18:30
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli merged commit dfe8528 into Project-MONAI:dev Sep 22, 2021
@wyli wyli mentioned this pull request Sep 22, 2021
1 task
@Nic-Ma Nic-Ma mentioned this pull request Nov 5, 2021
7 tasks
@wyli wyli deleted the fix-cucim-dep branch November 18, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants