Skip to content

Conversation

@neuronflow
Copy link
Contributor

@neuronflow neuronflow commented Sep 20, 2021

This PR implements a dimension check, before trying to load pre-trained model weights.

Fixes # .

Description

This PR implements a dimension check, before trying to load pre-trained model weights.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
Copy link
Contributor

wyli commented Sep 20, 2021

@neuronflow
Copy link
Contributor Author

sure, trying to find out how to do this in hindsight now :) I made the PR with the github web editor as it is so small.

@wyli
Copy link
Contributor

wyli commented Sep 20, 2021

/black
/build

neuronflow and others added 2 commits September 21, 2021 01:50
This PR implements a dimension check, before trying to load pre-trained model weights.

Signed-off-by: neuronflow <[email protected]>
Signed-off-by: monai-bot <[email protected]>
Signed-off-by: neuronflow <[email protected]>
@neuronflow
Copy link
Contributor Author

neuronflow commented Sep 21, 2021

Okay I hope I managed to fix it..also tests seem to pass locally. Your build pipeline this whole integration process is very cool!

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neuronflow
Copy link
Contributor Author

/home/runner/work/MONAI/MONAI/monai/networks/nets/densenet.py:311:151: B950 line too long (150 > 120 characters)
/home/runner/work/MONAI/MONAI/monai/networks/nets/densenet.py:337:151: B950 line too long (150 > 120 characters)
/home/runner/work/MONAI/MONAI/monai/networks/nets/densenet.py:363:151: B950 line too long (150 > 120 characters)
3     B950 line too long (150 > 120 characters)
3
Check failed!
Please run auto style fixes: ./runtests.sh --autofix
Error: Process completed with exit code 1.

@wyli
Hmm I did run the autofix and also monaibot would set the line length to 150. Could it be that there is a difference in settings for the automatic linting applied by @monai-bot and the test?

@wyli
Copy link
Contributor

wyli commented Sep 21, 2021

I think in this case the bot doesn't know how to break the long line, it has to be done manually at the moment...

@wyli wyli enabled auto-merge (squash) September 21, 2021 17:42
@wyli wyli merged commit f31b55f into Project-MONAI:dev Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants