-
Notifications
You must be signed in to change notification settings - Fork 1.4k
dimension check for pretrained model weights #2984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
sure, trying to find out how to do this in hindsight now :) I made the PR with the github web editor as it is so small. |
|
/black |
This PR implements a dimension check, before trying to load pre-trained model weights. Signed-off-by: neuronflow <[email protected]>
Signed-off-by: monai-bot <[email protected]> Signed-off-by: neuronflow <[email protected]>
|
Okay I hope I managed to fix it..also tests seem to pass locally. Your build pipeline this whole integration process is very cool! |
wyli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, the DCO looks good now, there is a minor style issue https://github.com/Project-MONAI/MONAI/pull/2984/checks?check_run_id=3663404181#step:7:116
@wyli |
|
I think in this case the bot doesn't know how to break the long line, it has to be done manually at the moment... |
Signed-off-by: neuronflow <[email protected]>
This PR implements a dimension check, before trying to load pre-trained model weights.
Fixes # .
Description
This PR implements a dimension check, before trying to load pre-trained model weights.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.