Skip to content

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Mar 4, 2020

Fixes #136 .

Description

This PR mainly contains the below features:

  1. Temporarily modify NiftiDataset to support classification tasks.
  2. Developed a 3D classification example based on temp dataset and DenseNet3D network.

Next Steps:

  1. @wyli will help to replace the dataset with a suitable public 3D classification dataset.
  2. I will try to refactor "load_nifti" as a transform and change Dataset class into a common Dataset.
    Will submit another PR because this will be a big change.

Status

Work in progress

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or new feature that would cause existing functionality to change)
  • New tests added to cover the changes
  • Docstrings/Documentation updated

@Nic-Ma Nic-Ma requested review from atbenmurray, ericspod and wyli March 4, 2020 11:41
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is the final version of nifti_dataset, would be great to include a unit test; otherwise it looks good to me

@Nic-Ma Nic-Ma merged commit cd4cc54 into master Mar 5, 2020
@wyli wyli deleted the 136-3d-classification-example branch May 21, 2020 13:33
wyli pushed a commit that referenced this pull request Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

image classification example

3 participants