Skip to content

fix: patch js-yaml and nanoid CVEs - #808

Merged
rootsongjc merged 1 commit into
Project-HAMi:masterfrom
mesutoezdil:fix/npm-audit-js-yaml-nanoid
Aug 21, 2026
Merged

fix: patch js-yaml and nanoid CVEs#808
rootsongjc merged 1 commit into
Project-HAMi:masterfrom
mesutoezdil:fix/npm-audit-js-yaml-nanoid

Conversation

@mesutoezdil

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Resolves two of the four open Dependabot alerts:

  • js-yaml: bumps the existing override from 4.3.0 to 4.3.1 for GHSA-5p4m-2wfm-xmqj (quadratic CPU consumption in !!omap resolution) and refreshes the lockfile so all js-yaml copies resolve to 4.3.1.
  • nanoid: lockfile update from 3.3.16 to 3.3.18 for GHSA-2v37-7h3g-55p8 (custom generators can loop indefinitely when size is zero). The postcss range already allows 3.3.18, so no override is needed.

The two remaining image-size alerts (GHSA-w3rx-r6r6-pgpr, GHSA-5p2g-fcmc-qvqq) have no patched release, every version up to the latest 2.0.2 is affected. image-size only runs at build time against images stored in this repository, so there is no runtime exposure; suggest dismissing those two alerts as build-time only until upstream ships a fix, matching how #706-era alerts were handled.

npm audit now reports image-size as the only remaining finding.

Which issue(s) this PR fixes:

N/A

Checklist:

  • npm run lint and npm run format:check pass
  • npm run build succeeds for both en and zh
  • Chinese translation updated if English docs changed (N/A, dependency update only)
  • Commits are signed off (git commit -s)

Bump the js-yaml override to 4.3.1 for GHSA-5p4m-2wfm-xmqj, the
quadratic CPU consumption in omap resolution, and refresh the lock
so every js-yaml copy resolves to 4.3.1. Update nanoid to 3.3.18
for GHSA-2v37-7h3g-55p8, the infinite loop with size zero.

The two image-size alerts have no patched release yet, all versions
up to 2.0.2 are affected. image-size only runs at build time on
repository images, so there is no runtime exposure on the site.

Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@hami-robot hami-robot Bot added the kind/bug Something isn't working label Aug 20, 2026
@netlify

netlify Bot commented Aug 20, 2026

Copy link
Copy Markdown

Deploy Preview for project-hami ready!

Name Link
🔨 Latest commit 44e4502
🔍 Latest deploy log https://app.netlify.com/projects/project-hami/deploys/6a87442f5262580007e1f9e9
😎 Deploy Preview https://deploy-preview-808--project-hami.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@hami-robot
hami-robot Bot requested review from archlitchi and wawa0210 August 20, 2026 18:15
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@mesutoezdil, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 48 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f2f084cb-9996-4b94-9b72-5f0d5828381d

📥 Commits

Reviewing files that changed from the base of the PR and between b5a333c and 44e4502.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hami-robot

hami-robot Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mesutoezdil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rootsongjc
rootsongjc merged commit 0743ca5 into Project-HAMi:master Aug 21, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants