feat: Improve GEO (Generative Engine Optimization): llms.txt, structured data, E-E-A-T signals - #781
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Anshumancanrock The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for project-hami ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Warning Review limit reached
Next review available in: 32 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (19)
✨ Finishing Touches 💡 2⚔️ Resolve merge conflicts 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
hi @rootsongjc , could you please review this PR? Thanks! |
mesutoezdil
left a comment
There was a problem hiding this comment.
well built: tests included, xss safe serialization, both svg variants exist, locale handling is right. coordination: the title promises llms.txt but the pr contains none, trim the title or add the file. #777 and #774 rewrite the same architecture.md, agree on an order. and the full concept page rewrite is backported into the frozen v2.9.0 snapshot, confirm maintainers want that.
|
|
||
| After completing the HAMi installation, the cluster is no longer an ordinary Kubernetes cluster, it becomes an AI infrastructure platform with GPU virtualization capabilities. This document breaks down the responsibilities and dependencies of every layer and every component in the cluster after installation. | ||
|
|
||
| :::note This page describes one NVIDIA-oriented reference deployment after installation, including optional components such as GPU Operator, Prometheus, and WebUI. For HAMi's product components and the request lifecycle, see [Architecture](./architecture.md). ::: |
There was a problem hiding this comment.
single line :::note text ::: does not render as an admonition, the markers show as literal text. put the closing ::: on its own line like the v2.9.0 zh copy does. same problem in the zh current copy.
There was a problem hiding this comment.
Fixed. Closing ::: is on its own line in EN current and ZH current, same as v2.9.0 zh.
| @@ -0,0 +1,177 @@ | |||
| const OFFICIAL_PROFILES = [ | |||
| "https://github.com/Project-HAMi", | |||
There was a problem hiding this comment.
are the linkedin and x handles real and owned by the project? a wrong sameAs actively hurts entity resolution.
There was a problem hiding this comment.
| ...(imageUrl && { image: imageUrl }), | ||
| inLanguage: schemaLanguage(locale), | ||
| ...(modifiedDate && { datePublished: modifiedDate, dateModified: modifiedDate }), | ||
| ...(version && { version }), |
There was a problem hiding this comment.
datePublished set to the last git update means every edit makes the article look newly published. either omit datePublished or source it separately.
There was a problem hiding this comment.
Done! Dropped datePublished. lastUpdatedAt only maps to dateModified now.
e2ebf12 to
2ca2c89
Compare
Signed-off-by: anshumancanrock <anshu.1239.as@gmail.com>
Signed-off-by: anshumancanrock <anshu.1239.as@gmail.com>
Signed-off-by: anshumancanrock <anshu.1239.as@gmail.com>
Signed-off-by: anshumancanrock <anshu.1239.as@gmail.com>
Signed-off-by: anshumancanrock <anshu.1239.as@gmail.com>
859c406 to
408e2a7
Compare
|
hii @mesutoezdil , addressed all your comments. Please take a look now and let me know if you want any other changes. Thanks! |
Signed-off-by: anshumancanrock <anshu.1239.as@gmail.com>


What type of PR is this?
/kind feature
What this PR does / why we need it:
Structured data, architecture overview, and trust pages for #658.
architecture.md is expanded. EN and ZH synced for docs/ and live v2.9.0. hami-architecture.md stays the NVIDIA reference deployment page.
Homepage JSON-LD: Organization and WebSite. No SearchAction. Docs emit TechArticle from the existing DocItem swizzle. showLastUpdateAuthor stays false.
New pages: /about, /privacy, /terms. Footer Legal column. Privacy and Terms link to LF Projects policies.
Which issue(s) this PR fixes:
#658
Checklist:
npm run lintandnpm run format:checkpassnpm run buildsucceeds for bothenandzhgit commit -s)