Skip to content

feat: Improve GEO (Generative Engine Optimization): llms.txt, structured data, E-E-A-T signals - #781

Open
Anshumancanrock wants to merge 6 commits into
Project-HAMi:masterfrom
Anshumancanrock:feat/geo-schema
Open

feat: Improve GEO (Generative Engine Optimization): llms.txt, structured data, E-E-A-T signals#781
Anshumancanrock wants to merge 6 commits into
Project-HAMi:masterfrom
Anshumancanrock:feat/geo-schema

Conversation

@Anshumancanrock

@Anshumancanrock Anshumancanrock commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Structured data, architecture overview, and trust pages for #658.

architecture.md is expanded. EN and ZH synced for docs/ and live v2.9.0. hami-architecture.md stays the NVIDIA reference deployment page.

Homepage JSON-LD: Organization and WebSite. No SearchAction. Docs emit TechArticle from the existing DocItem swizzle. showLastUpdateAuthor stays false.

New pages: /about, /privacy, /terms. Footer Legal column. Privacy and Terms link to LF Projects policies.

Which issue(s) this PR fixes:

#658

Checklist:

  • npm run lint and npm run format:check pass
  • npm run build succeeds for both en and zh
  • Chinese translation updated if English docs changed (or noted why not)
  • Commits are signed off (git commit -s)

@hami-robot hami-robot Bot added the kind/feature new function label Aug 16, 2026
@hami-robot
hami-robot Bot requested review from archlitchi and mesutoezdil August 16, 2026 08:10
@hami-robot

hami-robot Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Anshumancanrock
Once this PR has been reviewed and has the lgtm label, please assign windsonsea for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify

netlify Bot commented Aug 16, 2026

Copy link
Copy Markdown

Deploy Preview for project-hami ready!

Name Link
🔨 Latest commit 65999eb
🔍 Latest deploy log https://app.netlify.com/projects/project-hami/deploys/6a875c1902ccb100085c42b3
😎 Deploy Preview https://deploy-preview-781--project-hami.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@Anshumancanrock, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 32 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9d87eab4-d3fe-4bc9-a16a-3f217478c932

📥 Commits

Reviewing files that changed from the base of the PR and between b5a333c and 65999eb.

📒 Files selected for processing (19)
  • docs/core-concepts/architecture.md
  • docs/core-concepts/hami-architecture.md
  • docusaurus.config.js
  • i18n/zh/docusaurus-plugin-content-docs/current/core-concepts/architecture.md
  • i18n/zh/docusaurus-plugin-content-docs/current/core-concepts/hami-architecture.md
  • i18n/zh/docusaurus-plugin-content-docs/version-v2.9.0/core-concepts/architecture.md
  • i18n/zh/docusaurus-plugin-content-docs/version-v2.9.0/core-concepts/hami-architecture.md
  • i18n/zh/docusaurus-theme-classic/footer.json
  • src/components/JsonLd.js
  • src/pages/about.js
  • src/pages/index.js
  • src/pages/privacy.js
  • src/pages/terms.js
  • src/pages/trust.module.css
  • src/theme/DocItem/Layout/index.js
  • src/utils/jsonLd.js
  • src/utils/jsonLd.test.js
  • versioned_docs/version-v2.9.0/core-concepts/architecture.md
  • versioned_docs/version-v2.9.0/core-concepts/hami-architecture.md
✨ Finishing Touches 💡 2
⚔️ Resolve merge conflicts 💡
  • Resolve merge conflict in branch feat/geo-schema
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Anshumancanrock

Copy link
Copy Markdown
Contributor Author

hi @rootsongjc , could you please review this PR? Thanks!

@Anshumancanrock Anshumancanrock changed the title Feat/geo schema feat: geo schema Aug 16, 2026
@Anshumancanrock Anshumancanrock changed the title feat: geo schema feat: Improve GEO (Generative Engine Optimization): llms.txt, structured data, E-E-A-T signals Aug 16, 2026

@mesutoezdil mesutoezdil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well built: tests included, xss safe serialization, both svg variants exist, locale handling is right. coordination: the title promises llms.txt but the pr contains none, trim the title or add the file. #777 and #774 rewrite the same architecture.md, agree on an order. and the full concept page rewrite is backported into the frozen v2.9.0 snapshot, confirm maintainers want that.

Comment thread docs/core-concepts/hami-architecture.md Outdated

After completing the HAMi installation, the cluster is no longer an ordinary Kubernetes cluster, it becomes an AI infrastructure platform with GPU virtualization capabilities. This document breaks down the responsibilities and dependencies of every layer and every component in the cluster after installation.

:::note This page describes one NVIDIA-oriented reference deployment after installation, including optional components such as GPU Operator, Prometheus, and WebUI. For HAMi's product components and the request lifecycle, see [Architecture](./architecture.md). :::

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single line :::note text ::: does not render as an admonition, the markers show as literal text. put the closing ::: on its own line like the v2.9.0 zh copy does. same problem in the zh current copy.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Closing ::: is on its own line in EN current and ZH current, same as v2.9.0 zh.

Comment thread src/utils/jsonLd.js
@@ -0,0 +1,177 @@
const OFFICIAL_PROFILES = [
"https://github.com/Project-HAMi",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the linkedin and x handles real and owned by the project? a wrong sameAs actively hurts entity resolution.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes @mesutoezdil , these seem real and owned by hami

image image

Comment thread src/utils/jsonLd.js
...(imageUrl && { image: imageUrl }),
inLanguage: schemaLanguage(locale),
...(modifiedDate && { datePublished: modifiedDate, dateModified: modifiedDate }),
...(version && { version }),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

datePublished set to the last git update means every edit makes the article look newly published. either omit datePublished or source it separately.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Dropped datePublished. lastUpdatedAt only maps to dateModified now.

Signed-off-by: anshumancanrock <anshu.1239.as@gmail.com>
Signed-off-by: anshumancanrock <anshu.1239.as@gmail.com>
Signed-off-by: anshumancanrock <anshu.1239.as@gmail.com>
Signed-off-by: anshumancanrock <anshu.1239.as@gmail.com>
Signed-off-by: anshumancanrock <anshu.1239.as@gmail.com>
@Anshumancanrock

Copy link
Copy Markdown
Contributor Author

hii @mesutoezdil , addressed all your comments. Please take a look now and let me know if you want any other changes. Thanks!

Signed-off-by: anshumancanrock <anshu.1239.as@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants