chore: pin CodeRabbit label vocabulary to the kind/* scheme - #687
Conversation
|
@mesutoezdil: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for project-hami ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
CodeRabbit had no config, so it inferred labels from past pull requests and kept applying the flat enhancement label. Deleting that label did not stick, because adding a missing label through the API recreates it. Restrict suggestions to kind/bug, kind/feature, kind/documentation and kind/cleanup, and mark them mutually exclusive so a pull request cannot carry two type labels. area/* stays with .github/labeler.yml and priority/* stays a maintainer call. Validated against the CodeRabbit v2 config schema. Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
efab6f3 to
f494143
Compare
📝 WalkthroughWalkthroughAdds ChangesReview labeling configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested labels: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.coderabbit.yaml:
- Around line 19-27: Resolve the label contract mismatch in the CodeRabbit
configuration: either remove kind/cleanup from the mutually exclusive kind
labels and its auto-application rules, or update the related objective contract
to explicitly include kind/cleanup. Keep the configured label set and objective
requirements consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: bea4f548-0e98-4b29-8869-1308d46a5367
📒 Files selected for processing (1)
.coderabbit.yaml
| - label: kind/cleanup | ||
| instructions: Apply when the pull request refactors, reformats, or updates configuration and dependencies without changing behavior for site visitors. | ||
| mutually_exclusive_groups: | ||
| kind: | ||
| - kind/bug | ||
| - kind/feature | ||
| - kind/documentation | ||
| - kind/cleanup | ||
| auto_apply_labels: true |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== .coderabbit.yaml =="
cat -n .coderabbit.yaml || true
echo
echo "== occurrences of kind/cleanup and PR objective-ish wording =="
rg -n "kind/(bug|feature|documentation|cleanup)|PR objective|objective|suggest|apply|auto_apply_labels|coderabbit" -S . --glob '!node_modules/**' --glob '!dist/**' --glob '!build/**' || trueRepository: Project-HAMi/website
Length of output: 50376
Resolve the conflicting kind/cleanup label contract.
.coderabbit.yaml now permits and auto-applies kind/cleanup, but the PR objective contracts CodeRabbit to only kind/bug, kind/feature, and kind/documentation. Either remove kind/cleanup from the config or update the objective to explicitly include it.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.coderabbit.yaml around lines 19 - 27, Resolve the label contract mismatch
in the CodeRabbit configuration: either remove kind/cleanup from the mutually
exclusive kind labels and its auto-application rules, or update the related
objective contract to explicitly include kind/cleanup. Keep the configured label
set and objective requirements consistent.
Source: MCP tools
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mesutoezdil, rootsongjc The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Follow-up to the label discussion in #679. The flat
bug,enhancementanddocumentationlabels were deleted and the four issues that carriedenhancementare onkind/feature, but the delete does not hold on its own: CodeRabbit auto-applies labels here and, with no config in the repo, infers them from past PRs. Adding a missing label through the GitHub API recreates it, soenhancementcame straight back (see the label timeline on this PR, #682 and #684).This pins the vocabulary:
kind/bug,kind/feature,kind/documentationandkind/cleanupauto_apply_labels: truekeeps the current behavior, only with the right labelsarea/*is left to the path globs in.github/labeler.ymlandpriority/*stays a maintainer call, so this file does not touch either.On
kind/cleanup:.github/PULL_REQUEST_TEMPLATE.mdoffers/kind bug,/kind cleanup,/kind documentationand/kind feature, butkind/cleanupdid not exist as a label. Prow silently rejected it, which is the same class of bug #679 describes for the issue templates. The label now exists, so it belongs in this list too.Note on scope: CodeRabbit only reads
.coderabbit.yamlfrom the base branch for open source repos, so this has no effect until it lands onmaster. Until thenenhancementkeeps reappearing on new PRs. Deleting that label again after merge is the last step.Which issue(s) this PR fixes:
Relates to #679
Checklist:
npm run lintandnpm run format:checkpassnpm run buildsucceeds for bothenandzhgit commit -s)Notes on the checklist:
prettier --checkpasses on the new file, and the config validates against the CodeRabbit v2 config schema (schema.v2.json).Docs Health Check / Lint, Format, Build & Linkspassed on CI, which covers lint, format and the build for both locales..coderabbit.yamlis read by CodeRabbit only, it is not an input to Docusaurus.