Skip to content

fix parseNvidiaNumaInfo index out of range #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
archlitchi merged 1 commit into from
Feb 25, 2025
Merged

fix parseNvidiaNumaInfo index out of range #889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/device-plugin/nvidiadevice/nvinternal/plugin/register.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ func parseNvidiaNumaInfo(idx int, nvidiaTopoStr string) (int, error) {
}
klog.V(5).InfoS("nvidia-smi topo -m row output", "row output", words, "length", len(words))
if strings.Contains(words[0], fmt.Sprint(idx)) {
if words[numaAffinityColumnIndex] == "N/A" {
if len(words) <= numaAffinityColumnIndex || words[numaAffinityColumnIndex] == "N/A" {
klog.InfoS("current card has not established numa topology", "gpu row info", words, "index", idx)
return 0, nil
}
Expand Down
8 changes: 8 additions & 0 deletions pkg/device-plugin/nvidiadevice/nvinternal/plugin/register_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,14 @@ func Test_parseNvidiaNumaInfo(t *testing.T) {
want: 0,
wantErr: false,
},
{
name: "NUMA Affinity is empty",
idx: 0,
nvidiaTopoStr: `GPU0 CPU Affinity NUMA Affinity GPU NUMA ID
GPU0 X`,
want: 0,
wantErr: false,
},
}

for _, tt := range tests {
Expand Down