Skip to content

Fix NodeLock issue - #714

Merged
archlitchi merged 18 commits into
Project-HAMi:masterfrom
archlitchi:master
Dec 17, 2024
Merged

Fix NodeLock issue#714
archlitchi merged 18 commits into
Project-HAMi:masterfrom
archlitchi:master

Conversation

@archlitchi

Copy link
Copy Markdown
Member

/kind bug

There is an issue about nodelock release: "Pod B may accidentally release nodelock set by Pod A, which will cause multiple pending pod on node"

This pr add a lock owner check to avoid that from happening. So the only way pod B can release a lock set by Pod A, is the lock expires.

@archlitchi
archlitchi merged commit 050f91b into Project-HAMi:master Dec 17, 2024
@codecov

codecov Bot commented Dec 17, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 14.28571% with 18 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/util/nodelock/nodelock.go 0.00% 14 Missing ⚠️
pkg/device/devices.go 0.00% 2 Missing ⚠️
pkg/device/ascend/device.go 0.00% 1 Missing ⚠️
pkg/device/nvidia/device.go 0.00% 1 Missing ⚠️
Flag Coverage Δ
unittests 36.95% <14.28%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/scheduler/scheduler.go 34.25% <100.00%> (-0.83%) ⬇️
pkg/scheduler/score.go 64.83% <100.00%> (ø)
pkg/device/ascend/device.go 87.30% <0.00%> (ø)
pkg/device/nvidia/device.go 37.65% <0.00%> (ø)
pkg/device/devices.go 0.00% <0.00%> (ø)
pkg/util/nodelock/nodelock.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant