Fix NodeLock issue - #714
Merged
Merged
Conversation
Signed-off-by: limengxuan <391013634@qq.com>
Signed-off-by: limengxuan <391013634@qq.com>
Signed-off-by: limengxuan <391013634@qq.com>
Signed-off-by: limengxuan <391013634@qq.com>
Signed-off-by: limengxuan <391013634@qq.com>
Signed-off-by: limengxuan <391013634@qq.com>
Signed-off-by: limengxuan <391013634@qq.com>
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind bug
There is an issue about nodelock release: "Pod B may accidentally release nodelock set by Pod A, which will cause multiple pending pod on node"
This pr add a lock owner check to avoid that from happening. So the only way pod B can release a lock set by Pod A, is the lock expires.