fix(helm): Add NODE_NAME env var to the vgpu-monitor container from spec.nodeName - #687
Merged
Merged
Conversation
Nimbus318
force-pushed
the
fix/helm-node-name-env
branch
from
December 6, 2024 04:30
8a8541f to
e930c45
Compare
Member
|
@Nimbus318 can you rebase main branch? because having resolve code lint question. |
…pec.nodeName Signed-off-by: Nimbus318 <136771156+Nimbus318@users.noreply.github.com>
Nimbus318
force-pushed
the
fix/helm-node-name-env
branch
from
December 6, 2024 06:20
e930c45 to
bd7b3b7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
Author
|
@lengrongfu Rebased |
Member
|
/lgtm |
1 similar comment
Member
|
/lgtm |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #686
Special notes for your reviewer:
Does this PR introduce a user-facing change?: