Skip to content

fix: exception happen when creating multiple ascend-gpu pods concurrently - #575

Merged
archlitchi merged 1 commit into
Project-HAMi:masterfrom
lijm87:master
Dec 16, 2024
Merged

fix: exception happen when creating multiple ascend-gpu pods concurrently#575
archlitchi merged 1 commit into
Project-HAMi:masterfrom
lijm87:master

Conversation

@lijm87

@lijm87 lijm87 commented Oct 25, 2024

Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: exception occurred while creating multiple pods with ascend gpu concurrently

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@codecov

codecov Bot commented Oct 25, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/device/ascend/device.go 55.55% 6 Missing and 2 partials ⚠️
Flag Coverage Δ
unittests 32.61% <55.55%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/device/ascend/device.go 89.67% <55.55%> (-1.40%) ⬇️

@lijm87 lijm87 changed the title fix: exception occurred while creating multiple pods with ascend gpu concurrently fix: exception happen when creating multiple ascend-gpu pods concurrently Oct 25, 2024
@archlitchi

Copy link
Copy Markdown
Member

yes, nodelock is necessary for ascend jobs, but you need to implement 'release lock' part in 'ascend-device-plugin' for it to work

@lijm87

lijm87 commented Oct 31, 2024

Copy link
Copy Markdown
Contributor Author

yes, nodelock is necessary for ascend jobs, but you need to implement 'release lock' part in 'ascend-device-plugin' for it to work

done. together with PR in 'ascend-device-plugin': Project-HAMi/ascend-device-plugin#7

@archlitchi

Copy link
Copy Markdown
Member

hi, could you resolve this conflict? i'm going to integrate this PR in HAMi v2.5

@lijm87 lijm87 closed this Dec 13, 2024
@lijm87

lijm87 commented Dec 13, 2024

Copy link
Copy Markdown
Contributor Author

fix conflict

@lijm87 lijm87 reopened this Dec 13, 2024
…concurrently

Signed-off-by: junmin.li <junmin.li@zstack.io>
@lengrongfu

Copy link
Copy Markdown
Member

/lgtm

@archlitchi
archlitchi merged commit 2be5564 into Project-HAMi:master Dec 16, 2024
@fishman fishman mentioned this pull request Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants