Skip to content

fix stale claim that AMD node lock is unimplemented #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
im-Toqeer-506 wants to merge 1 commit into from
Closed

fix stale claim that AMD node lock is unimplemented #2708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/develop/amd-vgpu.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ HSA_CU_MASK=0:0-75;1:0-75
Each `CU_list` uses HSA's CU ID-list grammar, for example `0-3,8,10-12`.

Exclusivity of CU ranges across pods on a device is enforced under the AMD
node lock (`AMDDevices.LockNode` and `ReleaseNodeLock` which are unimplemented now).
node lock (`AMDDevices.LockNode` and `ReleaseNodeLock`).
Comment thread
archlitchi marked this conversation as resolved.

@mesutoezdil mesutoezdil Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong. both methods are still empty stubs, see device.go 119-125. the doc is correct as is. which commit did you check?


## 5. Resource model and core_limit -> CU mask

Expand Down
Loading