Repository navigation
fix(scheduler): reject filter requests with no candidate nodes #2687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1038,6 +1038,14 @@ func (s *Scheduler) Filter(args extenderv1.ExtenderArgs) (*extenderv1.ExtenderFi | |
| if args.Nodes != nil { | ||
| return s.filterSimulation(args, resourceReqs) | ||
| } | ||
| if args.NodeNames == nil { | ||
| // The live filter path has no candidate list to work with, and running it | ||
| // anyway would drop the pod from the scheduling caches for nothing. | ||
| err := fmt.Errorf("extender args contain neither Nodes nor NodeNames") | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. getNodesUsage never reads its NodeNames parameter, and calcScore scores every node. so is rejecting right, or is nil safe enough? |
||
| klog.ErrorS(err, "Rejecting filter request", "pod", klog.KObj(args.Pod)) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. which caller sends args with neither field set? |
||
| s.recordScheduleFilterResultEvent(args.Pod, EventReasonFilteringFailed, "", err) | ||
| return &extenderv1.ExtenderFilterResult{Error: err.Error()}, nil | ||
| } | ||
|
|
||
| if pi, ok := s.podManager.TakeAndDeletePod(args.Pod); ok { | ||
| s.quotaManager.RmUsage(args.Pod, pi.Devices) | ||
|
|
@@ -1058,7 +1066,7 @@ func (s *Scheduler) Filter(args extenderv1.ExtenderArgs) (*extenderv1.ExtenderFi | |
| } | ||
| if len((*nodeScores).NodeList) == 0 { | ||
| klog.V(4).InfoS("No available nodes meet the required scores", "pod", args.Pod.Name) | ||
| s.recordScheduleFilterResultEvent(args.Pod, EventReasonFilteringFailed, "", fmt.Errorf("no available node, %d nodes do not meet", len(*args.NodeNames))) | ||
| s.recordScheduleFilterResultEvent(args.Pod, EventReasonFilteringFailed, "", fmt.Errorf("no available node, %d nodes do not meet", nodeNamesLen(args.NodeNames))) | ||
| return &extenderv1.ExtenderFilterResult{ | ||
| FailedNodes: failedNodes, | ||
| }, nil | ||
|
|
@@ -1097,7 +1105,7 @@ func (s *Scheduler) Filter(args extenderv1.ExtenderArgs) (*extenderv1.ExtenderFi | |
| } | ||
| } | ||
|
|
||
| successMsg := genSuccessMsg(len(*args.NodeNames), m.NodeID, nodeScores.NodeList) | ||
| successMsg := genSuccessMsg(nodeNamesLen(args.NodeNames), m.NodeID, nodeScores.NodeList) | ||
| s.recordScheduleFilterResultEvent(args.Pod, EventReasonFilteringSucceed, successMsg, nil) | ||
| res := extenderv1.ExtenderFilterResult{NodeNames: &[]string{m.NodeID}} | ||
| return &res, nil | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.