docs: add Cluster Autoscaler scale-up simulation design - #2528
Conversation
Signed-off-by: spencercjh <jiahao.cai@dynamia.ai>
Signed-off-by: spencercjh <jiahao.cai@dynamia.ai>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe pull request adds a design document for HAMi-aware Cluster Autoscaler scale-up simulation. It defines scheduling flows, extender contracts, transient device state, validation results, unsupported scenarios, and remaining implementation work. ChangesHAMi-aware Cluster Autoscaler simulation
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/develop/dry-run-filter-design.md`:
- Around line 190-195: Add TLS certificate verification to the HTTPS extender
configuration by supplying the appropriate CA trust settings through tlsConfig,
including serverName or client credentials when required. If this example is
intentionally non-production, clearly mark the configuration as test-only
instead of leaving certificate verification implicitly disabled.
- Around line 207-215: Update the CA implementation requirements around extender
invocation to state that an omitted or empty managedResources list causes
kube-scheduler to call that extender for every Pod. Apply resource-intersection
filtering only when managedResources is non-empty, while preserving the existing
fast path for unrelated extenders.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 7ffc8bab-c28c-40b9-bacb-b137c57b0002
📒 Files selected for processing (1)
docs/develop/dry-run-filter-design.md
Signed-off-by: spencercjh <jiahao.cai@dynamia.ai>
Signed-off-by: spencercjh <jiahao.cai@dynamia.ai>
|
/assign @fishman |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
i think it looks good |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FouoF, spencercjh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Most of this Pull Request was generated or revised with the assistance of AI tools(Codex with GPT-5.6 Sol High). I have reviewed the resulting content and take full responsibility for its accuracy, security, licensing compliance, and inclusion in this project.
What type of PR is this?
/kind design
What this PR does / why we need it:
Adds a design document for integrating HAMi device scheduling with Cluster Autoscaler's scale-up simulation.
The document introduces Cluster Autoscaler, template nodes, warm node groups, and cold-zero node groups for readers who are not familiar with the autoscaler. It also explains why HAMi cannot determine device feasibility from a Node's
Allocatableresources alone and how a side-effect-free simulation filter can reuse HAMi's device-specificFit()logic.The document records the capability that has been validated for a single Pod in a warm node group, then describes the work that remains before the integration can be released: a separate simulation contract, complete filter results and failure details, stateful multi-Pod simulation, stable device profiles for template nodes, production deployment controls, and upstream Cluster Autoscaler support.
Which issue(s) this PR fixes:
None.
Special notes for your reviewer:
This is a documentation-only change. The implementation and validation evidence are linked from the document, including HAMi PR #2046 and the experimental Cluster Autoscaler branch. Markdown links, numeric values, URLs, and whitespace have been checked against the reviewed source document.
Does this PR introduce a user-facing change?:
No. It adds design documentation and does not change runtime behavior.
Summary by CodeRabbit