Skip to content

fix(vGPUmonitor): clamp corrupt device count from shared memory region #2497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Nitish08-08 wants to merge 1 commit into from
Closed

fix(vGPUmonitor): clamp corrupt device count from shared memory region #2497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions pkg/monitor/nvidia/v0/spec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ func (s Spec) DeviceMax() int {
}

func (s Spec) DeviceNum() int {
return int(s.sr.num)
return int(min(max(s.sr.num, 0), uint64(maxDevices)))
}

// activeProcs returns the process slots currently in use. procnum is read from
Expand Down Expand Up @@ -138,10 +138,8 @@ func (s Spec) DeviceSmUtil(idx int) uint64 {
}

func (s Spec) SetDeviceSmLimit(l uint64) {
idx := uint64(0)
for idx < s.sr.num {
for idx := 0; idx < s.DeviceNum(); idx++ {
s.sr.smLimit[idx] = l
idx += 1
}
}

Expand All @@ -158,10 +156,8 @@ func (s Spec) DeviceMemoryLimit(idx int) uint64 {
}

func (s Spec) SetDeviceMemoryLimit(l uint64) {
idx := uint64(0)
for idx < s.sr.num {
for idx := 0; idx < s.DeviceNum(); idx++ {
s.sr.limit[idx] = l
idx += 1
}
}

Expand Down
10 changes: 3 additions & 7 deletions pkg/monitor/nvidia/v1/spec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ func (s Spec) DeviceMax() int {
}

func (s Spec) DeviceNum() int {
return int(s.sr.num)
return int(min(max(s.sr.num, 0), uint64(maxDevices)))
}

// activeProcs returns the process slots currently in use. procnum is read from
Expand Down Expand Up @@ -152,10 +152,8 @@ func (s Spec) DeviceSmUtil(idx int) uint64 {
}

func (s Spec) SetDeviceSmLimit(l uint64) {
idx := uint64(0)
for idx < s.sr.num {
for idx := 0; idx < s.DeviceNum(); idx++ {
s.sr.smLimit[idx] = l
idx += 1
}
}

Expand All @@ -172,10 +170,8 @@ func (s Spec) DeviceMemoryLimit(idx int) uint64 {
}

func (s Spec) SetDeviceMemoryLimit(l uint64) {
idx := uint64(0)
for idx < s.sr.num {
for idx := 0; idx < s.DeviceNum(); idx++ {
s.sr.limit[idx] = l
idx += 1
}
}

Expand Down