Skip to content

feat(chart): add values.schema.json for Helm values validation #2441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
im-Toqeer-506 wants to merge 1 commit into from
Closed

feat(chart): add values.schema.json for Helm values validation #2441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/hami/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 2.9.0
version: 2.9.1

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: "2.9.0"
appVersion: "2.9.1"
Comment on lines 20 to +24

@coderabbitai coderabbitai Bot Aug 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

rg -n -C 3 'Chart\.AppVersion|appVersion|image:|repository:|tag:' charts/hami
rg -n '2\.9\.[01]' charts/hami

Repository: Project-HAMi/HAMi

Length of output: 13398

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

printf '%s\n' '--- Chart.yaml ---'
cat -n charts/hami/Chart.yaml | sed -n '1,80p'

printf '%s\n' '--- helpers image definitions ---'
cat -n charts/hami/templates/_helpers.tpl | sed -n '1,180p'

printf '%s\n' '--- version/imageTag references in repo ---'
rg -n 'v2\.9\.[01]|2\.9\.[01]|global\.imageTag|imageTag:' .

Repository: Project-HAMi/HAMi

Length of output: 10655

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

printf '%s\n' '--- Helm chart metadata references ---'
rg -n 'hami\.imageTagOrGlobal|hami\.image\(|Chart\.AppVersion|global\.imageTag|appVersion|v2\.9\.0|v2\.9\.1|imageTag' charts/hami hack docs CHANGELOG.md VERSION README.md

printf '%s\n' '--- Chart values defaults ---'
python3 - <<'PY'
from pathlib import Path
p=Path('charts/hami/values.yaml')
text=p.read_text()
for i,line in enumerate(text.splitlines(),1):
    if 'imageTag:' in line:
        print(f'{i}: {line}')
PY

Repository: Project-HAMi/HAMi

Length of output: 1860

Align appVersion with the released HAMi image tag.

VERSION, global.imageTag, README, and the CHANGELOG still point to HAMi v2.9.0, while appVersion is bumped to 2.9.1 without an explicit v2.9.1 default. Set appVersion/imageTag to an available HAMi release, or keep them at v2.9.0 unless this PR also introduces that release.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@charts/hami/Chart.yaml` around lines 20 - 24, Align the Chart.yaml appVersion
with the released HAMi image version used by VERSION, global.imageTag, README,
and CHANGELOG; retain v2.9.0 unless this change also introduces an available
v2.9.1 release, and ensure the corresponding imageTag default matches.


kubeVersion: ">= 1.18.0-0"

Expand Down
Loading
Loading