Skip to content

fix(test): set LimitSet on quota fixtures added in #2347 #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
veyron-kairo wants to merge 1 commit into from
Closed

fix(test): set LimitSet on quota fixtures added in #2347 #2408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pkg/scheduler/webhook_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,13 +486,13 @@ func TestFitResourceQuotaNonNvidia(t *testing.T) {
// One MLU vmemory unit is 256 MiB, so a limit of 100 units leaves room for
// 25600 MiB. Comparing the request against the raw 100 would deny every pod.
qm.Quotas["mlu-mem"] = &device.DeviceQuota{
"cambricon.com/mlu.smlu.vmemory": &device.Quota{Used: 0, Limit: 100},
"cambricon.com/mlu.smlu.vmemory": &device.Quota{Used: 0, Limit: 100, LimitSet: true},
}
qm.Quotas["mlu-core"] = &device.DeviceQuota{
"cambricon.com/mlu.smlu.vcore": &device.Quota{Used: 20, Limit: 50},
"cambricon.com/mlu.smlu.vcore": &device.Quota{Used: 20, Limit: 50, LimitSet: true},
}
qm.Quotas["dcu-mem"] = &device.DeviceQuota{
"hygon.com/dcumem": &device.Quota{Used: 0, Limit: 1000},
"hygon.com/dcumem": &device.Quota{Used: 0, Limit: 1000, LimitSet: true},
}
t.Cleanup(func() {
for _, ns := range []string{"mlu-mem", "mlu-core", "dcu-mem"} {
Expand Down Expand Up @@ -590,7 +590,7 @@ func TestFitResourceQuotaCountsEveryDevice(t *testing.T) {
qm := device.NewQuotaManager()
// 60 units is 15360 MiB of headroom.
qm.Quotas["mlu-multi"] = &device.DeviceQuota{
"cambricon.com/mlu.smlu.vmemory": &device.Quota{Used: 0, Limit: 60},
"cambricon.com/mlu.smlu.vmemory": &device.Quota{Used: 0, Limit: 60, LimitSet: true},
}
t.Cleanup(func() { delete(qm.Quotas, "mlu-multi") })

Expand Down Expand Up @@ -649,7 +649,7 @@ func TestFitResourceQuotaAscendMemoryFactor(t *testing.T) {

qm := device.NewQuotaManager()
qm.Quotas["ascend"] = &device.DeviceQuota{
"huawei.com/Ascend910B-memory": &device.Quota{Used: 0, Limit: 8192},
"huawei.com/Ascend910B-memory": &device.Quota{Used: 0, Limit: 8192, LimitSet: true},
}
t.Cleanup(func() { delete(qm.Quotas, "ascend") })

Expand Down
Loading