docs: document Prometheus metrics exposed by vGPU monitor - #2361
Conversation
Signed-off-by: khanskr <294885327+khanskr@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: khanskr The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @khanskr! It looks like this is your first PR to Project-HAMi/HAMi 🎉 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdded ChangesvGPU monitor metrics documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/metrics.md`:
- Around line 28-35: Update the Prometheus scraping example in the metrics
documentation to use the chart-generated ServiceMonitor instead of directly
scraping the NodePort address, or explicitly document that the NodePort Service
must use externalTrafficPolicy: Local for per-node scraping.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: d1a362a4-7de1-4a66-9df2-0cda55568b4a
📒 Files selected for processing (1)
docs/metrics.md
Signed-off-by: khanskr <294885327+khanskr@users.noreply.github.com>
|
docs/ only contains design document, for user-guide, you need to change the hami-website:https://github.com/Project-HAMi/website |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Adds docs/metrics.md documenting the Prometheus metrics exposed by the vGPU monitor (vGPUmonitor), including a description of each metric and example PromQL queries, as requested in issue #2356.
Which issue(s) this PR fixes:
Fixes #2356
Special notes for your reviewer:
Metric names, types, labels and value semantics were verified against the descriptors and collection code in cmd/vGPUmonitor/metrics.go and pkg/metrics/metrics.go. The bind address and legacy-metrics flags are documented from cmd/vGPUmonitor/main.go, and the scrape service configuration from the helm chart.
AI assistance disclosure:
The PR description was generated with AI assistance. No other part of this PR was generated with AI. I reviewed the change and take responsibility for it.
Does this PR introduce a user-facing change?:
NONE
Summary by CodeRabbit