fix(device): use len(devices) for GenReason in kunlun and awsneuron

[blackdragoon26]

What type of PR is this?
/kind bug

What this PR does / why we need it:

Kunlun XPU, Kunlun VXPU, and one AWS Neuron Fit failure path called common.GenReason(reason, len(reason)), so the denominator was the number of reason keys (usually 1) instead of candidate devices. That produced strings like 1/1 NumaNotFit instead of 1/8 NumaNotFit.
Other backends already use len(devices) after #2238; the AWS Neuron single-device fail path in the same file already did too. This PR updates the three remaining call sites and adds unit coverage.

Which issue(s) this PR fixes:
Fixes #2291

Special notes for your reviewer:

• Reason-string only; no allocation-policy change.
• Verified with go test ./pkg/device/kunlun/ ./pkg/device/awsneuron/ -count=1 -short and make verify.

Does this PR introduce a user-facing change?:
No

AI Assistance Disclosure: Used Cursor to help locate matching call sites and draft the initial test cases. I reviewed the change against the issue, ran the unit tests and make verify myself, and confirmed the reason-string behaviour before opening this PR.

Summary by CodeRabbit

• Bug Fixes

  • Corrected device allocation failure messages to report the total number of requested devices.
  • Improved NUMA-related allocation reasons for AWS Neuron and Kunlun devices.
  • Allocation conflicts now consistently report clear, accurate failure details.

• Tests

  • Added coverage for multi-device and NUMA-incompatible allocation failures.
  • Strengthened validation of allocation conflict reasons.

[coderabbitai]

Important

Review skipped

No new commits to review since the last review.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a17292d1-3752-4e8b-a39a-6af6c9effcb5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Walkthrough

AWS Neuron and Kunlun allocation failure reasons now use the total device count as the denominator. Tests cover NUMA-incompatible allocation and exact conflict reasons.

Changes

Device allocation failure reasons

Layer / File(s)	Summary
Update failure reason generation pkg/device/awsneuron/device.go, pkg/device/kunlun/device.go, pkg/device/kunlun/vdevice.go	Failure paths now pass the total device count to common.GenReason.
Add failure reason regression coverage pkg/device/awsneuron/device_test.go, pkg/device/kunlun/device_test.go	Tests verify exact NUMA and mutex allocation failure reasons. The unused import was removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• Project-HAMi/HAMi#2238: Fixes similar device-count reporting in allocation failure reasons.
• Project-HAMi/HAMi#2011: Modifies AWS Neuron and Kunlun allocation failure handling and tests.

Suggested reviewers: archlitchi

Poem

A rabbit counts cards in a row,
Now failure reasons clearly show.
NUMA says “one of two,”
Mutex conflicts state it true,
Clean tests guard the flow.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The changes address #2291 by fixing all three GenReason call sites and adding unit assertions for corrected failure reasons.
Out of Scope Changes check	✅ Passed	The changes are limited to the requested GenReason fixes, related tests, and removal of an unused import.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change to use len(devices) for GenReason in Kunlun and AWS Neuron.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag	Coverage Δ
unittests	60.88% <100.00%> (+0.22%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
pkg/device/awsneuron/device.go	76.05% <100.00%> (ø)
pkg/device/kunlun/device.go	18.48% <100.00%> (+7.56%)	⬆️
pkg/device/kunlun/vdevice.go	100.00% <100.00%> (+1.85%)	⬆️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pkg/device/awsneuron/device_test.go`:
- Around line 863-889: Update the “fit fail: NumaNotFit with multiple devices”
fixture so its devices have distinct DeviceUsage.Numa values rather than relying
on Index, and adjust the node-type/custom info and request fields to select a
graphSelect path that reaches NUMA-aware allocation for Nums == 2. Preserve the
expected 1/2 NumaNotFit result while ensuring the test genuinely exercises NUMA
incompatibility.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 33b81add-9c2c-432b-8d6c-621bd2e18e02

📥 Commits

Reviewing files that changed from the base of the PR and between 85192de and 4ac93e8.

📒 Files selected for processing (5)

• pkg/device/awsneuron/device.go
• pkg/device/awsneuron/device_test.go
• pkg/device/kunlun/device.go
• pkg/device/kunlun/device_test.go
• pkg/device/kunlun/vdevice.go

[blackdragoon26]

@CodeRabbit review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[mesutoezdil]

@CodeRabbit review

There is a limited number of tokens available for coderrabbit every day.
Please do not run this manually.

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

@mesutoezdil Understood. I will not run manual @CodeRabbit review actions on this pull request.

---

✏️ Learnings added

Learnt from: mesutoezdil
URL: https://github.com/Project-HAMi/HAMi/pull/2292

Timestamp: 2026-08-03T12:36:34.234Z
Learning: For Project-HAMi/HAMi pull requests, do not run manual `CodeRabbit review` actions. The repository has a limited daily CodeRabbit token budget. Use automatic reviews only unless a maintainer explicitly requests a manual review.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

_{You are interacting with an AI system.}

[archlitchi]

/lgtm

[hami-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: archlitchi, blackdragoon26

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [archlitchi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment