Fix: adopt to gangScheduling feature gates on k8s v1.36+

[archlitchi]

/kind bug

PR:#2066 only support coScheduling plugin, but doesn't support GangScheduling feature gate implemented in v1.36.

How to use:

1. Enable

  --feature-gates=GenericWorkload=true,GangScheduling=true

on kube-apiserver, kube-scheduler, kube-controller-manager

2. Then, for kube-apiserver, add the parameter below:

  --runtime-config=scheduling.k8s.io/v1alpha2=true

Example:

apiVersion: scheduling.k8s.io/v1alpha2
kind: PodGroup
metadata:
  name: test-fail-group
  namespace: default
spec:
  schedulingPolicy:
    gang:
      minCount: 2
---
apiVersion: v1
kind: Pod
metadata:
  name: e2e-test2-fail-pod1
  namespace: default
spec:
  schedulerName: hami-scheduler
  restartPolicy: Never
  schedulingGroup:
    podGroupName: test-fail-group
  containers:
  - name: c
    image: registry.k8s.io/pause:3.10.1
    resources:
      limits:
        hami-test.com/gpu: "1"
        hami-test.com/gpumem: "9000"
---
apiVersion: v1
kind: Pod
metadata:
  name: e2e-test2-fail-pod2
  namespace: default
spec:
  schedulerName: hami-scheduler
  restartPolicy: Never
  schedulingGroup:
    podGroupName: test-fail-group
  containers:
  - name: c
    image: registry.k8s.io/pause:3.10.1
    resources:
      limits:
        hami-test.com/gpu: "1"
        hami-test.com/gpumem: "9000"

Result:

I'll later add a user-guide to website

Summary by CodeRabbit

• Bug Fixes
  • Node lock contention errors are now consistently identified as retryable when multiple workloads attempt to lock the same node.
  • Pod group membership detection now recognizes both scheduler labels and native scheduling group configuration.
• Tests
  • Added coverage for concurrent node-lock attempts and pod group membership scenarios, including missing and empty configuration values.

[cursor]

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8860c669-1d43-4c18-a784-1727747f43af

📥 Commits

Reviewing files that changed from the base of the PR and between 6977dfa and 8f48438.

📒 Files selected for processing (1)

• pkg/util/nodelock/nodelock_test.go

🚧 Files skipped from review as they are similar to previous changes (1)

• pkg/util/nodelock/nodelock_test.go

---

📝 Walkthrough

Walkthrough

The change classifies duplicate node-lock errors with ErrNodeLockContention and adds concurrency coverage. It also expands IsPodGroupMember to recognize native scheduling groups and adds table-driven tests.

Changes

Node-lock contention classification

Layer / File(s)	Summary
Retryable node-lock contention pkg/util/nodelock/nodelock.go, pkg/util/nodelock/nodelock_test.go	SetNodeLock wraps duplicate-lock errors with ErrNodeLockContention. Tests cover concurrent lock attempts and preserve cleanup assertions.

PodGroup membership detection

Layer / File(s)	Summary
Label and scheduling-group membership pkg/util/util.go, pkg/util/util_test.go	IsPodGroupMember recognizes non-empty labels and native scheduling-group names. Tests cover nil, empty, label-based, native, and combined inputs.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• Project-HAMi/HAMi#2066: Updates overlapping node-lock contention handling and PodGroup membership logic.
• Project-HAMi/HAMi#2197: Updates node-lock contention wrapping and concurrent retryability tests.

Suggested labels: enhancement

Suggested reviewers: dsfans2014, fouof

Poem

I hop through locks, one holds the key,
The other retries predictably.
Labels and groups now join the show,
With tests to prove the paths we know.
A tidy patch beneath the moon.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: support for Kubernetes v1.36+ GangScheduling feature gates.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[archlitchi]

CC @mesutoezdil @FouoF

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag	Coverage Δ
unittests	63.00% <100.00%> (+0.19%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
pkg/util/nodelock/nodelock.go	70.14% <100.00%> (+2.98%)	⬆️
pkg/util/util.go	71.59% <100.00%> (+3.11%)	⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pkg/util/nodelock/nodelock_test.go`:
- Around line 457-483: Update TestSetNodeLockRaceIsRetryable and its comments to
reflect that the test performs sequential SetNodeLock calls and only verifies
the already-locked path, or rewrite it to run concurrent LockNode callers so it
actually exercises the race and validates retryable contention classification.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 03ec1363-9ce4-428d-b33a-45c7eebefc27

📥 Commits

Reviewing files that changed from the base of the PR and between 05e6c80 and 6977dfa.

📒 Files selected for processing (4)

• pkg/util/nodelock/nodelock.go
• pkg/util/nodelock/nodelock_test.go
• pkg/util/util.go
• pkg/util/util_test.go

[FouoF]

/lgtm

[hami-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: archlitchi, FouoF

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [FouoF,archlitchi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment