-
Notifications
You must be signed in to change notification settings - Fork 793
feat(metrics): add native node_name and pod labels to vGPUmonitor metrics #2153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
swastikCommits
wants to merge
2
commits into
Project-HAMi:master
from
swastikCommits:feat/instrument-vgpumonitor-node-pod-labels
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| /* | ||
| Copyright 2024 The HAMi Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package main | ||
|
|
||
| import ( | ||
| "os" | ||
| "strings" | ||
| "testing" | ||
|
|
||
| "github.com/prometheus/client_golang/prometheus" | ||
|
|
||
| "github.com/Project-HAMi/HAMi/pkg/util" | ||
| ) | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| func TestAllMetricDescriptorsIncludeNodeName(t *testing.T) { | ||
| ch := make(chan *prometheus.Desc, 30) | ||
| cc := ClusterManagerCollector{ | ||
| ClusterManager: &ClusterManager{ | ||
| LegacyMetrics: true, | ||
| }, | ||
| } | ||
| initLegacyDescriptors() | ||
|
|
||
| cc.Describe(ch) | ||
| close(ch) | ||
|
|
||
| descCount := 0 | ||
| for desc := range ch { | ||
| descCount++ | ||
| descStr := desc.String() | ||
| if strings.Contains(descStr, "fqName: \"hami_") { | ||
| if !strings.Contains(descStr, "node_name") { | ||
| t.Errorf("standard descriptor %s does not contain node_name label", descStr) | ||
| } | ||
| } else { | ||
| if !strings.Contains(descStr, "nodename") { | ||
| t.Errorf("legacy descriptor %s does not contain nodename label", descStr) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| expectedCount := 19 // 11 standard + 8 legacy descriptors | ||
| if descCount != expectedCount { | ||
| t.Errorf("expected exactly %d descriptors, got %d", expectedCount, descCount) | ||
| } | ||
| } | ||
|
|
||
| func TestGetNodeName(t *testing.T) { | ||
| // Environment variable set | ||
| testNode := "test-gpu-node-01" | ||
| t.Setenv(util.NodeNameEnvName, testNode) | ||
| if name := getNodeName(); name != testNode { | ||
| t.Errorf("expected getNodeName() to return %s, got %s", testNode, name) | ||
| } | ||
|
|
||
| // Environment variable unset | ||
| os.Unsetenv(util.NodeNameEnvName) | ||
| if name := getNodeName(); name != "" { | ||
| t.Errorf("expected getNodeName() to return empty string when env var is unset, got %s", name) | ||
| } | ||
| } | ||
|
|
||
| func TestSendMetric(t *testing.T) { | ||
| ch := make(chan prometheus.Metric, 5) | ||
|
|
||
| // Valid metric sending | ||
| err := sendMetric(ch, hostGPUdesc, prometheus.GaugeValue, 1024, "node-1", "0", "gpu-uuid-1", "NVIDIA-A100") | ||
| if err != nil { | ||
| t.Errorf("expected sendMetric to succeed, got %v", err) | ||
| } | ||
|
|
||
| // Legacy metric sending | ||
| initLegacyDescriptors() | ||
| sendLegacyMetric(ch, legacyHostGPUdesc, prometheus.GaugeValue, 1024, "node-1", "0", "gpu-uuid-1", "NVIDIA-A100") | ||
|
|
||
| close(ch) | ||
| count := 0 | ||
| for range ch { | ||
| count++ | ||
| } | ||
| if count != 2 { | ||
| t.Errorf("expected 2 metrics in channel, got %d", count) | ||
| } | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.