Skip to content

feat(helm): add switch for admission webhook namespaceSelector #2091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hami-robot merged 2 commits into from
Jul 21, 2026
+8 −0
Merged

feat(helm): add switch for admission webhook namespaceSelector #2091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e393a3
feat(helm): add switch for admission webhook namespaceSelector
spencercjh Jul 20, 2026
f4ec476
fix(helm): keep webhook namespaceSelector when value key is absent
spencercjh Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/hami/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ This document provides detailed descriptions of all configurable values paramete
| `scheduler.admissionWebhook.customURL.host` | Custom URL host | `127.0.0.1` |
| `scheduler.admissionWebhook.customURL.port` | Custom URL port | `31998` |
| `scheduler.admissionWebhook.customURL.path` | Custom URL path | `/webhook` |
| `scheduler.admissionWebhook.manageNamespaceSelector` | Whether the chart renders and manages the webhook namespaceSelector field | `true` |
| `scheduler.admissionWebhook.reinvocationPolicy` | Reinvocation policy | `Never` |
| `scheduler.admissionWebhook.failurePolicy` | Failure policy | `Ignore` |

Expand Down
2 changes: 2 additions & 0 deletions charts/hami/templates/scheduler/webhook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ webhooks:
failurePolicy: {{ .Values.scheduler.admissionWebhook.failurePolicy }}
matchPolicy: Equivalent
name: vgpu.hami.io
{{- if or (not (hasKey .Values.scheduler.admissionWebhook "manageNamespaceSelector")) .Values.scheduler.admissionWebhook.manageNamespaceSelector }}
namespaceSelector:
{{- if .Values.scheduler.admissionWebhook.namespaceSelector.matchLabels }}
matchLabels:
Expand All @@ -42,6 +43,7 @@ webhooks:
{{- if .Values.scheduler.admissionWebhook.namespaceSelector.matchExpressions }}
{{- toYaml .Values.scheduler.admissionWebhook.namespaceSelector.matchExpressions | nindent 6 }}
{{- end }}
{{- end }}
objectSelector:
{{- if .Values.scheduler.admissionWebhook.objectSelector.matchLabels }}
matchLabels:
Expand Down
5 changes: 5 additions & 0 deletions charts/hami/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,11 @@ scheduler:
# - default
# - kube-system
# - istio-system
# manageNamespaceSelector controls whether the chart renders and manages the webhook's
# namespaceSelector field. Keep it true on standard Kubernetes clusters.
# Set it to false on managed platforms (e.g. AKS) where the platform mutates and owns
# the namespaceSelector field, to avoid server-side apply ownership conflicts.
manageNamespaceSelector: true
# namespaceSelector controls which namespaces the webhook will be applied to.
# The default matchExpressions exclude namespaces with label "hami.io/webhook: ignore".
# You can add additional matchLabels or matchExpressions to further filter namespaces.
Expand Down
Loading