remove dra from charts

[archlitchi]

/kind cleanup

The right way to use HAMi-DRA is by following the document here:
https://project-hami.io/docs/installation/how-to-use-hami-dra

It's not elegant to mix that part with existing HAMi chart

Summary by CodeRabbit

• New Features
  • Simplified default chart configuration by removing DRA-related settings.
• Bug Fixes
  • Updated Helm rendering logic so device-plugin and scheduler manifests are no longer skipped based on DRA settings, and are included based on their own enablement flags.
  • Admission webhook–related scheduler resources (including cert-manager and RBAC pieces) now follow the intended admissionWebhook setting only.
• Chores
  • Removed the external DRA chart dependency to reduce installation/rendering surprises.

[archlitchi]

CC @Shouren

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e28bd4df-dc1b-4d0c-a82e-de04488f39b1

📥 Commits

Reviewing files that changed from the base of the PR and between bcad689 and 30b8fe3.

📒 Files selected for processing (1)

• charts/hami/templates/scheduler/clusterrole.yaml

💤 Files with no reviewable changes (1)

• charts/hami/templates/scheduler/clusterrole.yaml

---

📝 Walkthrough

Walkthrough

This PR removes the hami-dra Helm subchart dependency and deletes .Values.dra.enabled configuration. It also broadens device-plugin and scheduler template conditionals so resources render without the prior DRA gate, while admission-webhook templates now depend only on scheduler.admissionWebhook.enabled.

Changes

DRA Dependency and Conditional Gating Removal

Layer / File(s)	Summary
Chart dependency and values removal charts/hami/Chart.yaml, charts/hami/values.yaml	Removes the hami-dra dependency entry from Chart.yaml and deletes the dra/hami-dra configuration blocks from values.yaml.
Device-plugin template gating simplified charts/hami/templates/device-plugin/configmap.yaml, .../daemonsetnvidia.yaml, .../monitorrole.yaml, .../monitorrolebinding.yaml, .../monitorservice.yaml, .../monitorserviceaccount.yaml, .../runtime-class.yaml, .../servicemonitor.yaml	Removes the not .Values.dra.enabled requirement from device-plugin ConfigMap, DaemonSet, monitor RBAC/Service/ServiceAccount, RuntimeClass, and ServiceMonitor conditionals, leaving only devicePlugin.enabled (plus other existing checks).
Scheduler core resource gating removed charts/hami/templates/scheduler/clusterrole.yaml, .../clusterrolebinding.yaml, .../configmap.yaml, .../deployment.yaml, .../device-configmap.yaml, .../role.yaml, .../rolebinding.yaml, .../service.yaml, .../serviceaccount.yaml	Removes outer {{- if not .Values.dra.enabled -}} wrappers (and matching {{- end }}) from scheduler ClusterRole, ClusterRoleBinding, ConfigMap, Deployment, device-configmap, Role, RoleBinding, Service, and ServiceAccount templates so they render unconditionally or based on remaining flags.
Admission webhook job-patch gating simplified charts/hami/templates/scheduler/certmanager.yaml, .../job-patch/clusterrole.yaml, .../job-patch/clusterrolebinding.yaml, .../job-createSecret.yaml, .../job-patchWebhook.yaml, .../psp.yaml, .../role.yaml, .../rolebinding.yaml, .../serviceaccount.yaml, .../webhook.yaml	Removes the not .Values.dra.enabled clause from admission webhook related templates, leaving scheduler.admissionWebhook.enabled as the sole gating condition.

Estimated code review effort: 2 (Simple) | ~15 minutes

Poem

A rabbit hops through YAML fields so wide,
Snipping dra.enabled clauses cast aside.
No more gates, no more if not to check,
Every Role and Service renders, heck why wreck?
One less dependency, one lighter chart —
Hop on, dear cluster, this is a fresh start! 🐇✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is concise and clearly summarizes the main change: removing DRA from the charts.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[wawa0210]

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

---

cc @s descendants

[gemini-code-assist]

Code Review

This pull request removes the hami-dra dependency and all associated Dynamic Resource Allocation (DRA) configurations and conditional checks from the Helm chart. This includes deleting the hami-dra subchart dependency from Chart.yaml, removing DRA-related values from values.yaml, and simplifying various template files by removing the 'not .Values.dra.enabled' conditions. I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag	Coverage Δ
unittests	59.58% <ø> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Shouren]

/lgtm

[hami-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: archlitchi, Shouren

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [Shouren,archlitchi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment