build(deps): bump github.com/NVIDIA/go-nvml from 0.13.0-1.0.20260212130905-92cf8c963449 to 0.13.3-0 - #1993
Merged
hami-robot[bot] merged 2 commits intoJul 2, 2026
Conversation
Bumps [github.com/NVIDIA/go-nvml](https://github.com/NVIDIA/go-nvml) from 0.13.0-1.0.20260212130905-92cf8c963449 to 0.13.3-0. - [Release notes](https://github.com/NVIDIA/go-nvml/releases) - [Commits](https://github.com/NVIDIA/go-nvml/commits/v0.13.3-0) --- updated-dependencies: - dependency-name: github.com/NVIDIA/go-nvml dependency-version: 0.13.3-0 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
📝 WalkthroughWalkthroughThe PR updates ChangesNVML bus ID conversion
Dependency Update
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
github.com/NVIDIA/go-nvml v0.13.3-0 changed nvml.PciInfo.BusId from [32]uint8 to [32]int8. Update uint8Slice helper/test to int8Slice and adjust the conversion in GetNumaNode. Also run go mod tidy. Signed-off-by: Shouren Yang <yangshouren@gmail.com>
Shouren
force-pushed
the
dependabot/go_modules/github.com/NVIDIA/go-nvml-0.13.3-0
branch
from
July 2, 2026 08:13
f43c5e0 to
5bf3140
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
pkg/device-plugin/nvidiadevice/nvinternal/plugin/register.go (2)
68-87: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winDuplicate
GetNumaNodeimplementation.This package-level
GetNumaNodeis functionally identical tonvmlDevice.GetNumaNode()inpkg/device-plugin/nvidiadevice/nvinternal/rm/nvml_devices.go(same busID parsing, sysfs read, and NUMA node parsing logic). Worth consolidating to one implementation to reduce maintenance burden, especially since both now depend on theint8Sliceconversion introduced by this dependency bump.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pkg/device-plugin/nvidiadevice/nvinternal/plugin/register.go` around lines 68 - 87, The package-level GetNumaNode implementation duplicates the same PCI bus ID parsing, sysfs read, and NUMA node parsing logic already present in nvmlDevice.GetNumaNode, so consolidate the behavior into one shared implementation. Update GetNumaNode in register.go to delegate to the existing method or extract the common logic into a single helper used by both call sites, keeping the current error handling and return semantics unchanged.
52-64: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winDuplicate
int8Slice/String()implementation.This exact type and method are also defined in
pkg/device-plugin/nvidiadevice/nvinternal/rm/nvml_devices.goandpkg/device-plugin/nvidiadevice/nvinternal/rm/helper.go. Consider consolidating into a single shared helper (e.g. in an internal utility package) to avoid triplicated logic drifting out of sync across the three files.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pkg/device-plugin/nvidiadevice/nvinternal/plugin/register.go` around lines 52 - 64, The int8Slice and String implementation is duplicated across register.go, nvml_devices.go, and helper.go, so consolidate this logic into one shared helper and update the existing callers to use it. Keep the unique symbols int8Slice and String() as the entry points, but move the actual nil-terminated int8-to-string conversion into a single internal utility to prevent the three copies from drifting out of sync.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@pkg/device-plugin/nvidiadevice/nvinternal/plugin/register.go`:
- Around line 68-87: The package-level GetNumaNode implementation duplicates the
same PCI bus ID parsing, sysfs read, and NUMA node parsing logic already present
in nvmlDevice.GetNumaNode, so consolidate the behavior into one shared
implementation. Update GetNumaNode in register.go to delegate to the existing
method or extract the common logic into a single helper used by both call sites,
keeping the current error handling and return semantics unchanged.
- Around line 52-64: The int8Slice and String implementation is duplicated
across register.go, nvml_devices.go, and helper.go, so consolidate this logic
into one shared helper and update the existing callers to use it. Keep the
unique symbols int8Slice and String() as the entry points, but move the actual
nil-terminated int8-to-string conversion into a single internal utility to
prevent the three copies from drifting out of sync.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: b3d478e3-abb4-4f73-8db1-e556fa8a71c9
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (6)
go.modpkg/device-plugin/nvidiadevice/nvinternal/plugin/register.gopkg/device-plugin/nvidiadevice/nvinternal/plugin/register_test.gopkg/device-plugin/nvidiadevice/nvinternal/rm/helper.gopkg/device-plugin/nvidiadevice/nvinternal/rm/nvml_devices.gopkg/device-plugin/nvidiadevice/nvinternal/rm/nvml_devices_test.go
💤 Files with no reviewable changes (1)
- go.mod
✅ Files skipped from review due to trivial changes (1)
- pkg/device-plugin/nvidiadevice/nvinternal/rm/nvml_devices_test.go
🚧 Files skipped from review as they are similar to previous changes (3)
- pkg/device-plugin/nvidiadevice/nvinternal/rm/helper.go
- pkg/device-plugin/nvidiadevice/nvinternal/rm/nvml_devices.go
- pkg/device-plugin/nvidiadevice/nvinternal/plugin/register_test.go
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dependabot[bot], Shouren The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dependabot
Bot
deleted the
dependabot/go_modules/github.com/NVIDIA/go-nvml-0.13.3-0
branch
July 2, 2026 08:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps github.com/NVIDIA/go-nvml from 0.13.0-1.0.20260212130905-92cf8c963449 to 0.13.3-0.
Release notes
Sourced from github.com/NVIDIA/go-nvml's releases.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Summary by CodeRabbit