fix: return snapshot in InspectAllNodesUsage to avoid data race

[DSFans2014]

What type of PR is this?

/kind bug

What this PR does / why we need it:

• The metrics system reads the data returned by InspectAllNodesUsage. Since the underlying data may be concurrently modified, this could lead to a data race.
• Remove the unused member cachedstatus from scheduler

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[gemini-code-assist]

Code Review

This pull request improves concurrency safety by switching to read locks in GetPod and creating a deep-copied snapshot under a read lock in InspectAllNodesUsage. However, a critical data race remains because s.overviewstatus is updated concurrently in getNodesUsage without holding the lock. It is recommended to refactor getNodesUsage to return the maps so that callers can safely assign them under the lock.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[codecov]

Codecov Report

❌ Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
pkg/scheduler/scheduler.go	61.11%	7 Missing ⚠️

Flag	Coverage Δ
unittests	59.04% <65.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
pkg/device/pods.go	62.67% <100.00%> (ø)
pkg/scheduler/scheduler.go	52.88% <61.11%> (+0.08%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[mesutoezdil]

second commit (Jun 24) fixes the race: getNodesUsage no longer writes s.overviewstatus directly. Filter discards the return, register assigns under s.lock.Lock(). RLock in InspectAllNodesUsage is sufficient.

[archlitchi]

/lgtm

[hami-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: archlitchi, DSFans2014

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [DSFans2014,archlitchi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment