Skip to content

Support topology-awareness for Kunlunxin device - #1121

Merged
archlitchi merged 32 commits into
Project-HAMi:masterfrom
archlitchi:kunluncompat
Jun 18, 2025
Merged

Support topology-awareness for Kunlunxin device#1121
archlitchi merged 32 commits into
Project-HAMi:masterfrom
archlitchi:kunluncompat

Conversation

@archlitchi

Copy link
Copy Markdown
Member

/kind feature

We support kunlunxin device using the new-implemented API, which has been tested in production environment

archlitchi and others added 30 commits March 18, 2025 18:07
Signed-off-by: limengxuan <391013634@qq.com>
Signed-off-by: limengxuan <391013634@qq.com>
Signed-off-by: limengxuan <mengxuan.li@dynamia.ai>
Signed-off-by: limengxuan <mengxuan.li@dynamia.ai>
Signed-off-by: limengxuan <mengxuan.li@dynamia.ai>
Signed-off-by: limengxuan <mengxuan.li@dynamia.ai>
Signed-off-by: limengxuan <mengxuan.li@dynamia.ai>
Signed-off-by: limengxuan <mengxuan.li@dynamia.ai>
Signed-off-by: limengxuan <mengxuan.li@dynamia.ai>
Signed-off-by: limengxuan <mengxuan.li@dynamia.ai>
Signed-off-by: limengxuan <mengxuan.li@dynamia.ai>
Signed-off-by: limengxuan <mengxuan.li@dynamia.ai>
Signed-off-by: limengxuan <mengxuan.li@dynamia.ai>
Signed-off-by: root <mengxuan.li@dynamia.ai>
Signed-off-by: root <mengxuan.li@dynamia.ai>
Signed-off-by: root <mengxuan.li@dynamia.ai>
Signed-off-by: limengxuan <mengxuan.li@dynamia.ai>
Signed-off-by: root <mengxuan.li@dynamia.ai>
Signed-off-by: root <mengxuan.li@dynamia.ai>
@hami-robott

hami-robott Bot commented Jun 13, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: archlitchi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robott hami-robott Bot added the approved label Jun 13, 2025
@github-actions github-actions Bot removed the kind/feature new function label Jun 13, 2025
@hami-robott hami-robott Bot added the size/XL label Jun 13, 2025
@archlitchi

Copy link
Copy Markdown
Member Author

/assign @ouyangluwei163

Signed-off-by: root <mengxuan.li@dynamia.ai>
@codecov

codecov Bot commented Jun 13, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 42.90909% with 157 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/device/kunlun/device.go 43.30% 140 Missing and 4 partials ⚠️
pkg/device/cambricon/device.go 25.00% 2 Missing and 1 partial ⚠️
pkg/device/iluvatar/device.go 25.00% 2 Missing and 1 partial ⚠️
pkg/device/metax/device.go 25.00% 2 Missing and 1 partial ⚠️
pkg/device/mthreads/device.go 25.00% 2 Missing and 1 partial ⚠️
pkg/device/enflame/device.go 0.00% 1 Missing ⚠️
Flag Coverage Δ
unittests 51.89% <42.90%> (-1.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/scheduler/scheduler.go 45.78% <100.00%> (-5.38%) ⬇️
pkg/device/enflame/device.go 50.44% <0.00%> (ø)
pkg/device/cambricon/device.go 56.89% <25.00%> (-0.60%) ⬇️
pkg/device/iluvatar/device.go 53.84% <25.00%> (-0.75%) ⬇️
pkg/device/metax/device.go 41.20% <25.00%> (-0.59%) ⬇️
pkg/device/mthreads/device.go 58.13% <25.00%> (-0.69%) ⬇️
pkg/device/kunlun/device.go 43.30% <43.30%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ouyangluwei163

Copy link
Copy Markdown
Contributor

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants