fix(chart): support GKE pre-release versions via kubeVersion '-0' - #1072
Merged
Conversation
Member
|
/lgtm |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more. see 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Shouren
requested changes
May 23, 2025
…patibility with prerelease versions - Updates `kubeVersion` from '>= 1.16.0' to '>= 1.18.0-0' to support GKE pre-release versions like v1.32.3-gke.* - Updates README to reflect the minimum supported Kubernetes version Signed-off-by: Yu Yin <yu.yin@dynamia.ai>
Nimbus318
force-pushed
the
fix/kubeversion-gke
branch
from
May 23, 2025 02:58
d5badaf to
cc9c6a1
Compare
Shouren
approved these changes
May 23, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes Helm installation failure on GKE clusters where Kubernetes versions include a pre-release suffix (e.g.,
v1.32.3-gke.1785003). Helm uses Masterminds/semver, which by spec skips pre-releases when comparing against a constraint like>= 1.18.0.From the semver spec used by Helm:
Therefore, changing the constraint to
>= 1.18.0-0ensures compatibility with Kubernetes versions that use pre-release identifiers, including those from GKE and other distributions.Additionally, this PR updates the minimum supported Kubernetes version in the
READMEfrom 1.16 to 1.18, reflecting the current chart constraint.References:
Which issue(s) this PR fixes:
Fixes #1071
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
no