Devmem - #1
Merged
Merged
Conversation
bobsongplus
pushed a commit
to bobsongplus/HAMi
that referenced
this pull request
Oct 21, 2024
…e_type add mul device type use nvidia.com/gpu-h100 like requests/limits
youyos
pushed a commit
to youyos/HAMi
that referenced
this pull request
Jul 30, 2025
hami-robot Bot
pushed a commit
that referenced
this pull request
May 6, 2026
#1820) * fix(scheduler): guard against zero-value division in ComputeScore (#1780) ComputeScore and ComputeDefaultScore divide by device capacity fields (Count, Totalcore, Totalmem) without zero-checks. When any field is 0, float32 division produces NaN/Inf, which breaks sort.Sort's ordering requirement and causes an index-out-of-range panic — crashing the entire scheduler extender and halting all GPU scheduling cluster-wide. Return score 0 for devices/nodes with zero capacity so the scheduler can gracefully mark them as unschedulable instead of panicking. Signed-off-by: lin121291 <4jp33f9e@gmail.com> * fix(scheduler): add nil check for Device pointer in ComputeScore Signed-off-by: lin121291 <4jp33f9e@gmail.com> --------- Signed-off-by: lin121291 <4jp33f9e@gmail.com>
mesutoezdil
pushed a commit
to mesutoezdil/HAMi
that referenced
this pull request
Jun 14, 2026
…oject-HAMi#1… (Project-HAMi#1820) * fix(scheduler): guard against zero-value division in ComputeScore (Project-HAMi#1780) ComputeScore and ComputeDefaultScore divide by device capacity fields (Count, Totalcore, Totalmem) without zero-checks. When any field is 0, float32 division produces NaN/Inf, which breaks sort.Sort's ordering requirement and causes an index-out-of-range panic — crashing the entire scheduler extender and halting all GPU scheduling cluster-wide. Return score 0 for devices/nodes with zero capacity so the scheduler can gracefully mark them as unschedulable instead of panicking. Signed-off-by: lin121291 <4jp33f9e@gmail.com> * fix(scheduler): add nil check for Device pointer in ComputeScore Signed-off-by: lin121291 <4jp33f9e@gmail.com> --------- Signed-off-by: lin121291 <4jp33f9e@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initial merge