Patch 6 #2
Merged
Patch 6 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the unitended declaration of global variables.
Backward compatibility is kept.
Removes the undocumented audio functions.
The replay button is still unavailable.
Code prettyfying.
restore_file is much better at parsing SQL.
…ara#78, removes dead feeds HugoFara#148. Issue HugoFara#78: we do no longer need an explicit bypass of the default timestamp rule.
Issue HugoFara#151: langauges can be deleted and not only "hidden".
ProgramComputer
added a commit
that referenced
this pull request
Dec 30, 2023
* Patch 6 (#2) * Code clean-up with the audio controller. Remove the unitended declaration of global variables. * Refactor audio_controller in object namespace style. Backward compatibility is kept. * Fixes HugoFara#138: changing audio speed was partially broken. * Replaces calls to global audio functions by the new object. Removes the undocumented audio functions. * Avoid unnecessary function return type. * Fixes "text_id is unkown" on text opening. * Fixes warning on step 2 of feed wizard (related to HugoFara#129) * Reorders functions to be in logical declaration order. * Code cleaning. * Refactoring jq_feedwizard as object namespace. * Synctactic sugar on jq_feedwizard.js. * Adds an helper object to avoid one-line JS. * Prettyfies JS code. * Isolates JS code in feed wizard step 3. * Use json_encode to avoid PHP incursion in JS code. Code prettyfying. * Beautify JS and avoid calls to deprecated functions. * Fixes JS errors on feeds: xPath was not set, and it was sometimes leave step 2. * Beautifies demo DB as the users has the right to see what they install. * Fix: the demo database was unreadable since last commit. restore_file is much better at parsing SQL. * Stop reading demo on errors, syntactic suger. * Better detection of file end not read. * Changes WoStatusChange to a value that doesn't need configuration change (HugoFara#78). * Implementes HugoFara#148: removes dead feeds from demo database. * Fixes a bug introduced in a previous commit. Signalled by @ProgramComputer. * Fixes HugoFara#151: click delete on a language deletes the language. * Multi-image docker * Update docker-image.yml * Update docker-image.yml * Update docker-image.yml * Update docker-image.yml * Update docker-image.yml * Update docker-image.yml * Update docker-image.yml --------- Co-authored-by: HugoFara <[email protected]> * Update docker-image.yml * Update docker-image.yml * Update docker-image.yml * Update docker-image.yml * Update docker-image.yml * Update docker-image.yml * Update docker-image.yml * Update docker-image.yml * Update docker-image.yml * Update docker-image.yml * future php platforms * less vulnerabilities for larger size * Lwt is accessed at /lwt/ https://hugofara.github.io/lwt/docs/info.html#install * Update Dockerfile * Update docker-image.yml * Update Dockerfile --------- Co-authored-by: HugoFara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.