PHPOffice#293 : PowerPoint2007 Writer : Support autoscale for Chart

Progi1984 · Mar 6, 2017 · 97ffc75 · 97ffc75
1 parent 3d9d26c
commit 97ffc75
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -25,6 +25,7 @@
 - PowerPoint2007 Writer : Support text direction in Alignment for Table - @SeregPie GH-218
 - PowerPoint2007 Writer : Support tick mark & unit in Axis for Chart - @Faab GH-218
 - PowerPoint2007 Writer : Support separator in Series for Chart - @jphchaput GH-218
+- PowerPoint2007 Writer : Support autoscale for Chart - @Progi1984 GH-293
 - Misc : Added two methods for setting Border & Fill in Legend - @Progi1984 GH-265
 
 ## 0.7.0 - 2016-09-12

diff --git a/docs/shapes_chart.rst b/docs/shapes_chart.rst
@@ -145,6 +145,15 @@ You can define if some informations are displayed.
     $oSeries->setShowSeriesName(true);
     $oSeries->setShowValue(true);
 
+View3D
+^^^^^^
+
+For enabling the autoscale for a shape, you must reset the height percent.
+
+.. code-block:: php
+
+    $oShape->getView3D()->setHeightPercent(null);
+
 Types
 -----
 

diff --git a/src/PhpPresentation/Writer/PowerPoint2007/PptCharts.php b/src/PhpPresentation/Writer/PowerPoint2007/PptCharts.php
@@ -97,16 +97,15 @@ public function writeChart(Chart $chart)
         $objWriter->writeAttribute('val', $chart->getView3D()->getRotationX());
         $objWriter->endElement();
 
-        // c:hPercent
-        $objWriter->startElement('c:hPercent');
-        $objWriter->writeAttribute('val', $chart->getView3D()->getHeightPercent());
-        $objWriter->endElement();
-
         // c:rotY
         $objWriter->startElement('c:rotY');
         $objWriter->writeAttribute('val', $chart->getView3D()->getRotationY());
         $objWriter->endElement();
 
+        // c:hPercent
+        $hPercent = $chart->getView3D()->getHeightPercent();
+        $objWriter->writeElementIf($hPercent != null, 'c:hPercent', 'val', $hPercent);
+
         // c:depthPercent
         $objWriter->startElement('c:depthPercent');
         $objWriter->writeAttribute('val', $chart->getView3D()->getDepthPercent());

diff --git a/tests/PhpPresentation/Tests/Writer/PowerPoint2007/PptChartsTest.php b/tests/PhpPresentation/Tests/Writer/PowerPoint2007/PptChartsTest.php
@@ -843,4 +843,22 @@ public function testTypeScatterSuperScript()
         $this->assertZipXmlElementExists('ppt/charts/' . $oShape->getIndexedFilename(), $element);
         $this->assertZipXmlAttributeEquals('ppt/charts/' . $oShape->getIndexedFilename(), $element, 'baseline', '30000');
     }
+
+    public function testView3D()
+    {
+        $oSlide = $this->oPresentation->getActiveSlide();
+        $oLine = new Line();
+        $oLine->addSeries(new Series('Downloads', $this->seriesData));
+        $oShape = $oSlide->createChartShape();
+        $oShape->getPlotArea()->setType($oLine);
+
+        $element = '/c:chartSpace/c:chart/c:view3D/c:hPercent';
+        $this->assertZipXmlElementExists('ppt/charts/' . $oShape->getIndexedFilename(), $element);
+        $this->assertZipXmlAttributeEquals('ppt/charts/' . $oShape->getIndexedFilename(), $element, 'val', 100);
+
+        $oShape->getView3D()->setHeightPercent(null);
+        $this->resetPresentationFile();
+
+        $this->assertZipXmlElementNotExists('ppt/charts/' . $oShape->getIndexedFilename(), $element);
+    }
 }