Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update validation for inference rule #1256

Merged
merged 5 commits into from
Aug 19, 2024
Merged

update validation for inference rule #1256

merged 5 commits into from
Aug 19, 2024

Conversation

khemrajrathore
Copy link
Member

@khemrajrathore khemrajrathore commented Aug 19, 2024 •
edited
Loading

The PR adds patch for

  • Rule validation on inferences to support passing rules for endpoint_domain_with_literal and endpoint_domain_with_property_name
  • domain.headOption.get can result into error for rules having empty domains and needs to be handled- Reverting this change as it is causing issue in comparison report, @ankit-privado Needs to look into why this is happening - ThirdParties.SDK.Google.Firebase in Java comparison report

HiteshMah-Jan
HiteshMah-Jan previously approved these changes Aug 19, 2024
View reviewed changes
@khemrajrathore khemrajrathore merged commit efafc2c into main Aug 19, 2024
12 of 13 checks passed
@khemrajrathore khemrajrathore deleted the patch/inferenceValidator branch August 19, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HiteshMah-Jan HiteshMah-Jan HiteshMah-Jan left review comments

@ankit-privado ankit-privado Awaiting requested review from ankit-privado

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khemrajrathore @HiteshMah-Jan