Jest + reducing work done per block when constructing them #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rom1504
reviewed
Sep 4, 2017
block.js
Outdated
| return Block | ||
| } | ||
|
|
||
| // Generates a block map type => metadata => template block, so that block names don't |
|
don't get recomputed every time a block is requested |
|
I really don't think we should have lock files (here package-lock.json) in libraries. any thought about that @roblabla ? |
|
I don't actually care one iota, it's a file that will always get recreated when running npm install on node8. If you don't want it, maybe we ought to explicitly add it to .gitignore. Same goes for yarn.lock. |
|
Yup, lockfiles are good for binaries (E.G. flying-sheep) but not libraries |
|
Ah, we should probably merge (part of) that |
|
reopen if you still think that would be useful |
FreezeEngine
added a commit
to FreezeEngine/prismarine-block
that referenced
this pull request
Jan 3, 2025
extremeheat
added a commit
that referenced
this pull request
Jan 4, 2025
* Added getHashValue * Added getHash to Block * simplify and add test * Fixed hashing * Added other collided blocks * prismarine-block to global * Update index.js * Update index.d.ts * added 4 byte mask * Added sorting * Added getHashValue * Added getHash to Block * simplify and add test * Fixed hashing * Added other collided blocks * prismarine-block to global * Update index.js * Update index.d.ts * added 4 byte mask * Added sorting * Add back EOL for lint * Description corrections * Updated docs * Updated docs #2 --------- Co-authored-by: extremeheat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: