Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forge can be used #472

Closed
wants to merge 1 commit into from
Closed

Forge can be used #472

wants to merge 1 commit into from

Conversation

Cedware
Copy link

@Cedware Cedware commented Jan 30, 2017

Solves Issue #56

To connect to a server, which uses forge the forge options can be passed to the createBot Method.

example:

export const bot = mineflayer.createBot({
    host: 'localhost',
    port: 8080,
    username: '....',
    password: '...'
},{
    forgeMods:[
        {modid: 'treechopper', version: '1.1.1a'}
    ]
});

To connect to a server, which uses forge the forge options can be passed to the createBot  Method
@roblabla
Copy link
Member

roblabla commented Jan 31, 2017

So I'd rather forge support stays outside mineflayer. I believe it is already usable by doing this :

export const bot = mineflayer.createBot({/* options */});
var forgeHandshake = require('minecraft-protocol-forge').forgeHandshake;
forgeHandshake(bot._client, { /* forgeOptions */ });

(It'd be much appreciated if you could confirm this works :D)

We might want to add some documentation to minecraft-protocol-forge to explain how to use it with mineflayer though.

The reason why I'm a bit iffy with adding explicit forge support in mineflayer is because none of the core devs actually use forge, so it's all pretty untested, and it looks like it should work rather well without actual support in the core.

@Cedware
Copy link
Author

Cedware commented Jan 31, 2017

Your suggestion works as well as my modifications.
So I think it's totally okay to keep the forge support outside the project

@rom1504
Copy link
Member

rom1504 commented Jun 4, 2017

replaced by #522

@rom1504 rom1504 closed this Jun 4, 2017
@1ProCrafters 1ProCrafters mentioned this pull request Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants