updating activateItem #3445
updating activateItem #3445
Conversation
lib/plugins/inventory.js
Outdated
| @@ -122,17 +124,26 @@ function inject (bot, { hideErrors }) { | |||
| }) | |||
| } else if (bot.supportFeature('useItemWithOwnPacket')) { | |||
| bot._client.write('use_item', { | |||
| hand: offHand ? 1 : 0 | |||
| hand: offHand ? 1 : 0, | |||
| sequence: ++sequence | |||
There was a problem hiding this comment.
Does this always increment? Can you put this increment operation up top as opposed to inside the packet body?
There was a problem hiding this comment.
Yes, to my knowledge it always increments. Decided to spam until it passed 8bit mark; I'm not going to continue doing so further.
I'll update the code, but personally I feel moving it upwards is unnecessary.
|
The checks are failing for reasons completely unrelated to my changes. Just a head's up. My changes are not breaking, I have run the tests on my local machine. It is timeouts causing issues. |
|
What I mean by moving it upward is moving it out of the feature check and keeping it as a proper internal counter. |
|
Could the 1.18.2 CI be rerun? This error has nothing to do with me. |
Oh! I'm not sure earlier versions have, hence why I put in a feature check. I can just move the sequence increment itself. |
|
|
||
| if (bot.supportFeature('useItemWithOwnPacket')) { | ||
| body.face = 0 | ||
| body.sequence = 0 |
There was a problem hiding this comment.
Note, you can supply extra fields on packets without any problems. If the field is not used on a particular version it will be ignored. I'm curious why the sequence is always 0 here, is it being reset or just fixed to 0?
There was a problem hiding this comment.
It is just fixed to zero. I have no idea to be honest. It doesn't change the sequence count.
I decided to add a feature support there since I wasn't sure if the face affected anything and just wanted to be as legitimate as possible without disrupting the original face (5)'s implementation.
bot.activateItemandbot.deactivateItemboth fail on new version of anticheat due to not specifying the sequence.For using a bow:
For eating (duplicate use_item due to immediately attempting to eat the next food)
For using a shield:
I do not believe there are any breaking changes.