Extend every window that is opened #2768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do you want to finish this ? |
IceTank
changed the title
|
I think this should work |
|
That method name is way too vague |
This was referenced Dec 22, 2022
This was referenced Feb 13, 2023
This was referenced Jun 12, 2023
This was referenced Jun 29, 2023
This was referenced Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all windows that are emitted with windowOpen include withdraw, deposit and close.
Especially close is really important when having windows open. I am not 100% sure if withdraw and deposit work with all types off windows that can be opened. Maybe someone can test it?