Implement protodef-yaml for mcpc #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
extremeheat
commented
Jun 23, 2024
extremeheat
commented
- Implement protodef-yaml for mcpc
- Support pc in incrementVersion script
Fix not updating protocol/version in dataPath for newest version
|
it does look pretty good do you think we can do anything about older versions? |
|
I think we should update docs for explaining contributors where they need to update the protocol info |
|
sorry for the delay in reviewing, I've been pretty busy in last months. This looks pretty good! One last thing I am noticing is the addition of default void in many places; which seems incorrect to me. For most switches the default is not void. There is no default! In protodef it means it will fail if value is not among the specified choices. |
Fix protodef-yaml setting switch defaults to void
rom1504
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.