Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition Creation Fixes #60

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

kwokcb
Copy link
Contributor

@kwokcb kwokcb commented Apr 11, 2024

Issue

Fixes: #61

  • The logic for definition creation creates invalid functional graphs.
  • nodegroup names are arbitrary instead of following the standard names.
  • The UI labels were incorrectly calling nodegroups "category", and category identifiers were called "name".

Changes

  • Update to remove inputs from the nodegraph with the currently checked in interface : addNodeDefFromNodeGraph.
  • Fix up to remove undesired attributes such as node position
  • Scan for available nodegroup names and only allow those to be used at creation time. Uses can modify this latter if they wish but arbtirary group names is undesired especially as this is being formalized in the specification.
  • Check for duplicate definition signatures being created. Put up a warning but allow for overwrite.

Example

Modified UI example:

image

@manuelkoester
Copy link
Member

Awesome! Great contribution. The drop down is a great idea :)

I also noticed that the "..." button doesn't do anything.. I'll fix that.
I would also like to see some ❔ button next to Node Group and Category telling the user what each of these mean in the context of QuiltiX and MaterialX.
I'll create an issue for this.

@manuelkoester manuelkoester merged commit 0f73f0d into PrismPipeline:main Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Definition creation logic is creating invalid function graphs
2 participants