In addition to waiting for all promises to settle, handle post-hoc additions/removals - #3961
Merged
Merged
Conversation
DmitrySharabin
commented
Jun 16, 2025
| if (!this.config.manual) { | ||
| this.waitFor.push(documentReady()); | ||
|
|
||
| this.ready = allSettled(this.waitFor); |
Member
Author
There was a problem hiding this comment.
We don't need this workaround anymore: we set the initial value of ready on line 35.
DmitrySharabin
force-pushed
the
all-settled-ad-hoc
branch
from
June 17, 2025 04:26
e7e002b to
c7b5e87
Compare
DmitrySharabin
changed the title
LeaVerou
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Credit: https://github.com/mavoweb/mavo/blob/78efe2b9cadd09c1d131b8afd5fe2f38d5cfa8c7/src/mavo.js#L845
Partially addresses #3960