Before highlighting code, resolve the language if its definition is already loaded, and it is not yet resolved#3951
Merged
DmitrySharabin merged 1 commit intosimplifyfrom May 29, 2025
Conversation
DmitrySharabin
commented
May 29, 2025
| env.language = prism.languageRegistry.getLanguage(env.languageDef); | ||
| } | ||
|
|
||
| prism.hooks.run('before-tokenize', env); |
Member
Author
There was a problem hiding this comment.
I thought the hook should have the full context during the run, so I decided to add this code before calling it. Am I right?
LeaVerou
reviewed
May 29, 2025
| }; | ||
|
|
||
| if (env.languageDef && !env.language) { | ||
| env.language = prism.languageRegistry.getLanguage(env.languageDef); |
Member
There was a problem hiding this comment.
Suggested change
| env.language = prism.languageRegistry.getLanguage(env.languageDef); | |
| // NOTE is this the best place to manage this logic? | |
| env.language = prism.languageRegistry.getLanguage(env.languageDef); |
LeaVerou
approved these changes
May 29, 2025
Member
LeaVerou
left a comment
LeaVerou
left a comment
There was a problem hiding this comment.
Not 100% sure this is the best place to manage this logic, but in the interest of progress, let's merge it.
Member
Author
|
Me neither. I just couldn't find a better place. 🤷♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, one can write a code that looks correct but will throw (necessary imports are omitted):