Bug fixes (the simplify branch)#3943
Merged
DmitrySharabin merged 7 commits intosimplifyfrom May 28, 2025
Merged
Conversation
DmitrySharabin
commented
May 26, 2025
DmitrySharabin
commented
May 26, 2025
src/languages/aspnet.ts
Outdated
| import csharp from './csharp'; | ||
| import markup from './markup'; | ||
| import type { Grammar, GrammarOptions, LanguageProto } from '../types'; | ||
| import type { Grammar, GrammarToken, LanguageProto } from '../types'; |
Member
Author
There was a problem hiding this comment.
By bad. I transformed this language incorrectly before.
DmitrySharabin
commented
May 26, 2025
LeaVerou
reviewed
May 28, 2025
src/languages/aspnet.ts
Outdated
| }, | ||
| $rest: 'csharp', | ||
| grammar ({ base }): Grammar { | ||
| const pageDirectiveInside: Grammar = { |
Member
Author
There was a problem hiding this comment.
Hm, something is wrong with the changes I propose. I took the language definition from the v2 branch, not the simplify branch. Let me remove it from the PR for now. We'll return to it later.
LeaVerou
approved these changes
May 28, 2025
Member
LeaVerou
left a comment
LeaVerou
left a comment
There was a problem hiding this comment.
See question but otherwise LGTM
Member
Author
If you are referring to the ASP.NET language and why we renamed the variable, I removed this language from this PR to update it correctly later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extend()