Some suggestions to the simplify branch#3939
Merged
DmitrySharabin merged 6 commits intosimplifyfrom May 18, 2025
Merged
Conversation
Member
DmitrySharabin
commented
May 18, 2025
DmitrySharabin
commented
- A bit more types and type assertions
- Fix some imports
- Fix the build script
- Prettier in the touched files
DmitrySharabin
commented
May 18, 2025
| } | ||
|
|
||
| return ret; | ||
| return ret as Grammar | undefined | Function; |
Member
Author
There was a problem hiding this comment.
TS can't infer that ret can't be of type string in the end (even though we have a branch that checks that ret is a string and where we update its value, so it's no longer a string).
LeaVerou
approved these changes
May 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.