Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will disallow regexes with parsing ambiguities.
The ECMAScript specification has a whole chapter on how regex parsing ambiguities are to be resolved. In practice, this means that we might not be required to escape some source characters (e.g.
]
,{
) even though it would improve readability. Parsing without ambiguity is also required to utilize newer regex features like named capturing groups and the Unicode flag.Adding this rule has two main advantages:
\[
) will always be escaped and non-source characters (e.g.=
) are forbidden to be escaped.Consistent escaping is really nice for code review because a lot of people do unnecessary escaping.