Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pure-Rust version of libsamplerate #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

3c1u
Copy link

@3c1u 3c1u commented Feb 23, 2020

This enables to build rust-samplerate without a C compiler and CMake, etc... using https://github.com/RamiHg/rust-libsamplerate , a transpiled version of libsamplerate. This might helps to use this crate on some platforms (e.g. Windows/MSVC).

@Prior99
Copy link
Owner

Prior99 commented Mar 1, 2020

Thanks for your contribution. I took a look at the pure-rust version. It looks to me like there is no automated way to upgrade to incoming changes from the upstream repository. Is that correct?

@3c1u
Copy link
Author

3c1u commented Mar 2, 2020

That seems to be correct, and of course there is no guarantee that it will be upgraded.

LLVM and clang are required to run C2Rust, which is more than C/C++ development requirements. A bot or something similar which transpiles the upstream repo might be required.

@Prior99
Copy link
Owner

Prior99 commented Mar 2, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants