Repository navigation
fix(v1): report platform run errors - #2577
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a focused one-file fix that reports existing platform run errors through the current incomplete-status path. It does not alter evaluation execution, run finalization, or persistence behavior. You can add or adjust custom eligibility rules. Learn more. |
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
mikasenghaas
added a commit
that referenced
this pull request
Sep 14, 2026
Main moved the eval CLI's platform upload onto prime-runs (#2415, #2569, #2577) and taught the runner `run.attach`. All of that lives in files this branch deletes, so the merge keeps the deletions and drops the new `tests/v1/test_platform_run.py` with them. Nothing in verifiers imports `prime_runs` any more, so the dependency goes too; prime-rl depends on it directly. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prime-runsupdate and finalization errors through the existing incomplete upload statusValidation
uv run pytest tests/ -q(credential-gated E2E cases skipped)uv run ruff check --fix .uv run ty check verifiersuv run pre-commit run --all-filesNote
Low Risk
Small change to how incomplete upload messages are assembled after
run.finish(); improves visibility without altering eval or push control flow.Overview
Platform push “incomplete” reporting now includes
prime-runsrun-level errors (e.g. update/finalization failures), not only per-sink failed records and uploader overruns._lossesbuilds its message fromrun.errorsfirst, then the existing failed-record and dropped-record details, so a run that closes successfully can still show an incomplete footer line when the SDK recorded errors during the lifecycle.Reviewed by Cursor Bugbot for commit 0b14aaf. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Include
run.errorsin platform_lossesloss descriptionUpdates the
_lossesutility in platform.py to prepend the run's existing errors to the returned semicolon-separated loss message, before failed-record and dropped-record messages. The message still returnsNonewhen no messages are present.Macroscope summarized 0b14aaf.