vf-tui parsing crashes when tool_calls contains JSON strings instead of dicts #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nancyjlau
changed the title
|
awesome! thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the vf-tui viewer to properly handle tool_calls when they are stored as JSON strings instead of dictionary objects. This issue was preventing vf-tui from displaying tool calls for certain environments that serialize tool_calls as JSON strings in their output. I encountered this issue when testing viewing results on the ARC-AGI 1 + 2 with tool calling environment, more info about runs at my env PR
Type of Change
Testing
python -m pytest tests/Test Coverage
Additional Notes
After fix