Skip to content

fix: require aiohttp>=3.14.1 (interception uses web.RequestKey) - #2451

Merged
hallerite merged 1 commit into
codex/rlm-lineagefrom
fix/aiohttp-requestkey-min-version
Aug 27, 2026
Merged

fix: require aiohttp>=3.14.1 (interception uses web.RequestKey)#2451
hallerite merged 1 commit into
codex/rlm-lineagefrom
fix/aiohttp-requestkey-min-version

Conversation

@hallerite

@hallerite hallerite commented Aug 27, 2026

Copy link
Copy Markdown
Member

verifiers/v1/interception/server.py uses aiohttp.web.RequestKey (added in aiohttp 3.14), but pyproject.toml pins aiohttp>=3.9.0. An env that resolves 3.9–3.13 (e.g. 3.13.5) crashes at import:

AttributeError: module 'aiohttp.web' has no attribute 'RequestKey'. Did you mean: 'Request'?

Bump the floor to aiohttp>=3.14.1 to match the code. Found while dogfooding this branch (nano-rlm lineage eval).

🤖 Generated with Claude Code

Note

Require aiohttp>=3.14.1 in pyproject.toml

Bumps the minimum aiohttp version from >=3.9.0 to >=3.14.1 because the interception code relies on web.RequestKey, which is available only in newer releases. Risk: environments pinned to an older aiohttp will fail dependency resolution on install.

Macroscope summarized 3689d12.


Note

Low Risk
Dependency constraint only; no runtime logic changes. Environments that must stay on aiohttp <3.14 will fail resolution on install instead of crashing at import.

Overview
Raises the declared aiohttp floor in pyproject.toml from >=3.9.0 to >=3.14.1 so installs match what the v1 interception server already assumes.

verifiers/v1/interception/server.py registers typed request context via web.RequestKey (e.g. idempotent rollout attempts). That API exists only from aiohttp 3.14 onward; resolving 3.9–3.13 previously led to an AttributeError at import time.

Reviewed by Cursor Bugbot for commit 3689d12. Bugbot is set up for automated code reviews on this repo. Configure here.

verifiers/v1/interception/server.py imports `from aiohttp import web` and calls
`web.RequestKey(...)` (added in aiohttp 3.14), but the dependency pin was
`aiohttp>=3.9.0`. Environments resolving an older aiohttp (e.g. 3.13.x) crash at
import time with `AttributeError: module 'aiohttp.web' has no attribute 'RequestKey'`.
Bump the floor to 3.14.1 to match actual usage.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@hallerite
hallerite marked this pull request as ready for review August 27, 2026 13:46
@hallerite
hallerite merged commit 8465071 into codex/rlm-lineage Aug 27, 2026
5 checks passed
@hallerite
hallerite deleted the fix/aiohttp-requestkey-min-version branch August 27, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant