fix: require aiohttp>=3.14.1 (interception uses web.RequestKey) - #2451
Merged
Conversation
verifiers/v1/interception/server.py imports `from aiohttp import web` and calls `web.RequestKey(...)` (added in aiohttp 3.14), but the dependency pin was `aiohttp>=3.9.0`. Environments resolving an older aiohttp (e.g. 3.13.x) crash at import time with `AttributeError: module 'aiohttp.web' has no attribute 'RequestKey'`. Bump the floor to 3.14.1 to match actual usage. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
hallerite
marked this pull request as ready for review
August 27, 2026 13:46
hallerite
added a commit
that referenced
this pull request
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verifiers/v1/interception/server.pyusesaiohttp.web.RequestKey(added in aiohttp 3.14), butpyproject.tomlpinsaiohttp>=3.9.0. An env that resolves 3.9–3.13 (e.g. 3.13.5) crashes at import:Bump the floor to
aiohttp>=3.14.1to match the code. Found while dogfooding this branch (nano-rlm lineage eval).🤖 Generated with Claude Code
Note
Require
aiohttp>=3.14.1inpyproject.tomlBumps the minimum
aiohttpversion from>=3.9.0to>=3.14.1because the interception code relies onweb.RequestKey, which is available only in newer releases. Risk: environments pinned to an olderaiohttpwill fail dependency resolution on install.Macroscope summarized 3689d12.
Note
Low Risk
Dependency constraint only; no runtime logic changes. Environments that must stay on aiohttp <3.14 will fail resolution on install instead of crashing at import.
Overview
Raises the declared
aiohttpfloor inpyproject.tomlfrom>=3.9.0to>=3.14.1so installs match what the v1 interception server already assumes.verifiers/v1/interception/server.pyregisters typed request context viaweb.RequestKey(e.g. idempotent rollout attempts). That API exists only from aiohttp 3.14 onward; resolving 3.9–3.13 previously led to anAttributeErrorat import time.Reviewed by Cursor Bugbot for commit 3689d12. Bugbot is set up for automated code reviews on this repo. Configure here.