Skip to content

fix(v1): use typed ACP turn in RLM harness - #2442

Merged
mikasenghaas merged 1 commit into
mainfrom
codex/fix-main-acp-turn
Aug 26, 2026
Merged

fix(v1): use typed ACP turn in RLM harness#2442
mikasenghaas merged 1 commit into
mainfrom
codex/fix-main-acp-turn

Conversation

@hallerite

@hallerite hallerite commented Aug 26, 2026

Copy link
Copy Markdown
Member

Summary

Root cause

PR #2439 retained the earlier ACPTurnResult name while PR #2438 landed the public type as ACPTurn. Importing the built-in harness package therefore raised ImportError.

Validation

  • exact deterministic V1 CI command: 71 passed
  • full test suite: 915 passed, 75 credential-gated skips
  • uv run ty check verifiers
  • uv run ruff check --fix .
  • changed-file pre-commit hooks

The all-files Markdown hook still reports the pre-existing inline-HTML table in verifiers/legacy/envs/experimental/composable/tasksets/swe/README.md, as already documented in PR #2438.


Note

Low Risk
Type-name alignment only; no change to RLM turn handling or metrics recording logic.

Overview
Updates the RLM harness so it imports and uses ACPTurn from verifiers.v1.acp instead of the obsolete ACPTurnResult name on the import and on acp_turn_result.

This matches the public ACP base type from the merged stack and fixes ImportError when built-in harness discovery loads the RLM package.

Reviewed by Cursor Bugbot for commit 3d87235. Bugbot is set up for automated code reviews on this repo. Configure here.

@macroscopeapp

macroscopeapp Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — The PR makes only the two type-name updates needed to align the RLM harness with the ACP type exported and produced by the current base implementation. It restores RLM harness loading without altering turn processing, metrics recording, or other runtime behavior.

Not approved because:

  • Monthly spending limit reached (workspace setting). Approvability relies on correctness review in order to determine eligibility

Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more.

@mikasenghaas
mikasenghaas merged commit b082e3c into main Aug 26, 2026
13 checks passed
@mikasenghaas
mikasenghaas deleted the codex/fix-main-acp-turn branch August 26, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants