fix(v1): use typed ACP turn in RLM harness - #2442
Merged
Merged
Conversation
Contributor
ApprovabilityVerdict: Would Approve Macroscope's review found this PR approvable — The PR makes only the two type-name updates needed to align the RLM harness with the ACP type exported and produced by the current base implementation. It restores RLM harness loading without altering turn processing, metrics recording, or other runtime behavior. Not approved because:
Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more. |
mikasenghaas
approved these changes
Aug 26, 2026
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
PR #2439 retained the earlier ACPTurnResult name while PR #2438 landed the public type as ACPTurn. Importing the built-in harness package therefore raised ImportError.
Validation
The all-files Markdown hook still reports the pre-existing inline-HTML table in verifiers/legacy/envs/experimental/composable/tasksets/swe/README.md, as already documented in PR #2438.
Note
Low Risk
Type-name alignment only; no change to RLM turn handling or metrics recording logic.
Overview
Updates the RLM harness so it imports and uses
ACPTurnfromverifiers.v1.acpinstead of the obsoleteACPTurnResultname on the import and onacp_turn_result.This matches the public ACP base type from the merged stack and fixes
ImportErrorwhen built-in harness discovery loads the RLM package.Reviewed by Cursor Bugbot for commit 3d87235. Bugbot is set up for automated code reviews on this repo. Configure here.